[Bugfix] Fix NPE in ReplicaShardAllocator (#13993) #14385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
DaniilRoman
force-pushed
the
fix-npe-in-replicashardallocator
branch
from
e2fbc24
to
4063a06
Compare
|
❌ Gradle check result for b18d572: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for e2fbc24: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 4063a06: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
DaniilRoman
force-pushed
the
fix-npe-in-replicashardallocator
branch
from
4063a06
to
d0cd50c
Compare
|
❕ Gradle check result for d0cd50c: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14385 +/- ##
============================================
+ Coverage 71.91% 71.93% +0.02%
+ Complexity 62516 62493 -23
============================================
Files 5145 5145
Lines 293307 293309 +2
Branches 42407 42407
============================================
+ Hits 210919 211003 +84
+ Misses 65040 64953 -87
- Partials 17348 17353 +5 ☔ View full report in Codecov by Sentry. |
DaniilRoman
force-pushed
the
fix-npe-in-replicashardallocator
branch
from
d0cd50c
to
f96ce27
Compare
|
❌ Gradle check result for f96ce27: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Daniil Roman <[email protected]>
DaniilRoman
force-pushed
the
fix-npe-in-replicashardallocator
branch
from
f96ce27
to
ff59718
Compare
DaniilRoman
commented
Jun 18, 2024
DaniilRoman
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh and
nknize
as code owners
|
Hi team 👋 |
dblock
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
This looks good, but I am not super familiar with this part of the code, maybe @andrross or @mch2 can double-check this?
@DaniilRoman This fixes a bug, so add to CHANGELOG.
Signed-off-by: Daniil Roman <[email protected]>
# Conflicts: # CHANGELOG.md
|
@dblock thank you for looking at 🙏 I added it to CHANGELOG and I see I need to add a label |
|
❌ Gradle check result for 47d96c2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
dblock
approved these changes
Jul 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
* [Bugfix] Fix NPE in ReplicaShardAllocator (#13993) Signed-off-by: Daniil Roman <[email protected]> * Add fix info to CHANGELOG.md Signed-off-by: Daniil Roman <[email protected]> --------- Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Daniil Roman <[email protected]> (cherry picked from commit cf0d6cc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
Thanks for fixing this @DaniilRoman, backport is running. |
dblock
pushed a commit
that referenced
this pull request
Jul 19, 2024
* [Bugfix] Fix NPE in ReplicaShardAllocator (#13993) * Add fix info to CHANGELOG.md --------- (cherry picked from commit cf0d6cc) Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kaushalmahi12
pushed a commit
to kaushalmahi12/OpenSearch
that referenced
this pull request
Jul 23, 2024
…pensearch-project#14385) * [Bugfix] Fix NPE in ReplicaShardAllocator (opensearch-project#13993) Signed-off-by: Daniil Roman <[email protected]> * Add fix info to CHANGELOG.md Signed-off-by: Daniil Roman <[email protected]> --------- Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Daniil Roman <[email protected]>
kaushalmahi12
pushed a commit
to kaushalmahi12/OpenSearch
that referenced
this pull request
Jul 23, 2024
…pensearch-project#14385) * [Bugfix] Fix NPE in ReplicaShardAllocator (opensearch-project#13993) Signed-off-by: Daniil Roman <[email protected]> * Add fix info to CHANGELOG.md Signed-off-by: Daniil Roman <[email protected]> --------- Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
…pensearch-project#14385) (opensearch-project#14827) * [Bugfix] Fix NPE in ReplicaShardAllocator (opensearch-project#13993) * Add fix info to CHANGELOG.md --------- (cherry picked from commit cf0d6cc) Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <[email protected]>
mch2
pushed a commit
that referenced
this pull request
Jul 30, 2024
…de level (#14708) * add logic to add headers to Task Signed-off-by: Kaushal Kumar <[email protected]> * add logic to add queryGroupId to task headers Signed-off-by: Kaushal Kumar <[email protected]> * remove redundant code Signed-off-by: Kaushal Kumar <[email protected]> * add changelog entry Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * fix precommit Signed-off-by: Kaushal Kumar <[email protected]> * Add UTs for RemoteIndexMetadataManager (#14660) Signed-off-by: Shivansh Arora <[email protected]> Co-authored-by: Arpit-Bandejiya <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix match_phrase_prefix_query not working on text field with multiple values and index_prefixes (#10959) * Fix match_phrase_prefix_query not working on text field with multiple values and index_prefixes Signed-off-by: Gao Binlong <[email protected]> * Add more test Signed-off-by: Gao Binlong <[email protected]> * modify change log Signed-off-by: Gao Binlong <[email protected]> * Fix test failure Signed-off-by: Gao Binlong <[email protected]> * Change the indexAnalyzer used by prefix field Signed-off-by: Gao Binlong <[email protected]> * Skip old version for yaml test Signed-off-by: Gao Binlong <[email protected]> * Optimize some code Signed-off-by: Gao Binlong <[email protected]> * Fix test failure Signed-off-by: Gao Binlong <[email protected]> * Modify yaml test description Signed-off-by: Gao Binlong <[email protected]> * Remove the name parameter for setAnalyzer() Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Offline calculation of total shard per node and caching it for weight calculation inside LocalShardBalancer (#14675) Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * [bug fix] validate lower bound for top n size (#14587) Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Create SystemIndexRegistry with helper method matchesSystemIndex (#14415) * Create new extension point in SystemIndexPlugin for a single plugin to get registered system indices Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * WIP on system indices from IndexNameExpressionResolver Signed-off-by: Craig Perkins <[email protected]> * Add test in IndexNameExpressionResolverTests Signed-off-by: Craig Perkins <[email protected]> * Remove changes in SystemIndexPlugin Signed-off-by: Craig Perkins <[email protected]> * Add method in IndexNameExpressionResolver to get matching system indices Signed-off-by: Craig Perkins <[email protected]> * Show how resolver can be chained to get system indices Signed-off-by: Craig Perkins <[email protected]> * Fix forbiddenApis check Signed-off-by: Craig Perkins <[email protected]> * Update CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Make SystemIndices internal Signed-off-by: Craig Perkins <[email protected]> * Remove unneeded changes Signed-off-by: Craig Perkins <[email protected]> * Fix CI failures Signed-off-by: Craig Perkins <[email protected]> * Fix precommit errors Signed-off-by: Craig Perkins <[email protected]> * Use Regex instead of WildcardMatcher Signed-off-by: Craig Perkins <[email protected]> * Address code review feedback Signed-off-by: Craig Perkins <[email protected]> * Allow caller to pass index expressions Signed-off-by: Craig Perkins <[email protected]> * Create SystemIndexRegistry Signed-off-by: Craig Perkins <[email protected]> * Update CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Remove singleton limitation Signed-off-by: Craig Perkins <[email protected]> * Add javadoc Signed-off-by: Craig Perkins <[email protected]> * Add @experimentalapi annotation Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Refactor Grok validate pattern to iterative approach (#14206) * grok validate patterns recusrion to iterative Signed-off-by: Sandesh Kumar <[email protected]> * Add max depth in resolving a pattern to avoid OOM Signed-off-by: Sandesh Kumar <[email protected]> * change path from deque to arraylist Signed-off-by: Sandesh Kumar <[email protected]> * rename queue to stack Signed-off-by: Sandesh Kumar <[email protected]> * Change max depth to 500 Signed-off-by: Sandesh Kumar <[email protected]> * typo originPatternName fix Signed-off-by: Sandesh Kumar <[email protected]> * spotless Signed-off-by: Sandesh Kumar <[email protected]> --------- Signed-off-by: Sandesh Kumar <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump opentelemetry from 1.39.0 to 1.40.0 (#14674) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump jackson from 2.17.1 to 2.17.2 (#14687) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add release notes for release 1.3.18 (#14699) Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump reactor from 3.5.19 to 3.5.20 (#14697) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add unit tests for read flow of RemoteClusterStateService and bug fix for transient settings (#14476) Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Update version check for the bug fix of match_phrase_prefix_query not working on text field with multiple values and index_prefixes (#14703) Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Remove unnecessary cast to int from test (#14696) Signed-off-by: Lukáš Vlček <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * print reason why parent task was cancelled (#14604) Signed-off-by: kkewwei <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Use set of shard routing for shard in unassigned shard batch check. (#14533) Signed-off-by: Swetha Guptha <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add versioning for UploadedIndexMetadata (#14677) * Add versioning for UploadedIndexMetadata * Handle componentPrefix for backward compatibility Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix: update help output for _cat (#14722) * fixed help output for _cat Signed-off-by: ahmedsobeh <[email protected]> * updated changelog Signed-off-by: ahmedsobeh <[email protected]> * updated changelog Signed-off-by: ahmedsobeh <[email protected]> --------- Signed-off-by: ahmedsobeh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix hdfs-fixture kerb-admin & hadoop-minicluster dependencies are not being updated / false positive reports on CVEs (#14729) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Update to Gradle 8.9 (#14574) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix hdfs-fixture hadoop-minicluster dependencies are not being updated / false positive reports on CVEs (#14732) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add `strict_allow_templates` dynamic mapping option (#14555) * The dynamic mapping parameter supports strict_allow_templates Signed-off-by: Gao Binlong <[email protected]> * Modify change log Signed-off-by: Gao Binlong <[email protected]> * Modify skip version in yml test file Signed-off-by: Gao Binlong <[email protected]> * Refactor some code Signed-off-by: Gao Binlong <[email protected]> * Keep the old methods Signed-off-by: Gao Binlong <[email protected]> * change public to private Signed-off-by: Gao Binlong <[email protected]> * Optimize some code Signed-off-by: Gao Binlong <[email protected]> * Do not override toString method for Dynamic Signed-off-by: Gao Binlong <[email protected]> * Optimize some code and modify the changelog Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump net.minidev:json-smart from 2.5.0 to 2.5.1 in /plugins/repository-azure (#14748) * Bump net.minidev:json-smart in /plugins/repository-azure Bumps [net.minidev:json-smart](https://github.com/netplex/json-smart-v2) from 2.5.0 to 2.5.1. - [Release notes](https://github.com/netplex/json-smart-v2/releases) - [Commits](netplex/json-smart-v2@2.5.0...2.5.1) --- updated-dependencies: - dependency-name: net.minidev:json-smart dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * remove query insights plugin from core (#14743) Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add `strict_allow_templates` dynamic mapping option (#14555) (#14737) (#14742) * The dynamic mapping parameter supports strict_allow_templates * Modify change log * Modify skip version in yml test file * Refactor some code * Keep the old methods * change public to private * Optimize some code * Do not override toString method for Dynamic * Optimize some code and modify the changelog --------- (cherry picked from commit 6b8b3ef) Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * Fix create or update alias API doesn't throw exception for unsupported parameters (#14719) * Fix create or update alias API doesn't throw exception for unsupported parameters Signed-off-by: Gao Binlong <[email protected]> * Update version check in yml test Signed-off-by: Gao Binlong <[email protected]> * modify change log Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Remove query categorization from core (#14759) * Remove query categorization from core Signed-off-by: Siddhant Deshmukh <[email protected]> * Add changelog Signed-off-by: Siddhant Deshmukh <[email protected]> * Trigger Build Signed-off-by: Siddhant Deshmukh <[email protected]> --------- Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add changes to propagate queryGroupId across child requests and nodes (#14614) * add query group header propagator Signed-off-by: Kaushal Kumar <[email protected]> * apply spotless check Signed-off-by: Kaushal Kumar <[email protected]> * add new propagator in ThreadContext Signed-off-by: Kaushal Kumar <[email protected]> * spotlessApply Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * Bump com.microsoft.azure:msal4j from 1.15.1 to 1.16.0 in /plugins/repository-azure (#14610) * Bump com.microsoft.azure:msal4j in /plugins/repository-azure Bumps [com.microsoft.azure:msal4j](https://github.com/AzureAD/microsoft-authentication-library-for-java) from 1.15.1 to 1.16.0. - [Release notes](https://github.com/AzureAD/microsoft-authentication-library-for-java/releases) - [Changelog](https://github.com/AzureAD/microsoft-authentication-library-for-java/blob/dev/changelog.txt) - [Commits](AzureAD/microsoft-authentication-library-for-java@v1.15.1...v1.16.0) --- updated-dependencies: - dependency-name: com.microsoft.azure:msal4j dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * [Bugfix] Fix ICacheKeySerializerTests flakiness (#14564) * Fix testInvalidInput flakiness Signed-off-by: Peter Alfonsi <[email protected]> * Addressed andrross's comment Signed-off-by: Peter Alfonsi <[email protected]> * rerun security check Signed-off-by: Peter Alfonsi <[email protected]> --------- Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Correct typo in method name (#14621) Signed-off-by: vatsal <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Refactoring FilterPath.parse by using an iterative approach instead of recursion. (#14200) * Refactor FilterPath parse function (#12067) Signed-off-by: Robin Friedmann <[email protected]> * Implement unit tests for FilterPathTests (#12067) Signed-off-by: Robin Friedmann <[email protected]> * Write warn log if Filter is empty; Add comments (#12067) Signed-off-by: Robin Friedmann <[email protected]> * Add changelog Signed-off-by: Siddhant Deshmukh <[email protected]> * Remove unnecessary log statement Signed-off-by: Siddhant Deshmukh <[email protected]> * Remove unused logger Signed-off-by: Siddhant Deshmukh <[email protected]> * Spotless apply Signed-off-by: Siddhant Deshmukh <[email protected]> * Remove incorrect changelog Signed-off-by: Siddhant Deshmukh <[email protected]> --------- Signed-off-by: Siddhant Deshmukh <[email protected]> Co-authored-by: Robin Friedmann <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Removing String format in RemoteStoreMigrationAllocationDecider to optimise performance(#14612) Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Clear templates before Adding; Use NamedWriteableAwareStreamInput for RemoteCustomMetadata; Correct the check for deciding upload of HashesOfConsistentSettings (#14513) * Clear templates before Adding; Use NamedWriteableAwareStreamInput for RemoteCustomMetadata * Correct the check for deciding upload of hashes of consistent settings Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * add changelog Signed-off-by: Kaushal Kumar <[email protected]> * add PR link changelog Signed-off-by: Kaushal Kumar <[email protected]> * Improve reroute performance by optimising List.removeAll in LocalShardsBalancer to filter remote search shard from relocation decision (#14613) Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix assertion failure while deleting remote backed index (#14601) Signed-off-by: Sachin Kale <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Allow system index warning in OpenSearchRestTestCase.refreshAllIndices (#14635) * Allow system index warning Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Address code review comments Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Star tree codec changes (#14514) --------- Signed-off-by: Bharathwaj G <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump com.github.spullara.mustache.java:compiler from 0.9.13 to 0.9.14 in /modules/lang-mustache (#14672) * Bump com.github.spullara.mustache.java:compiler Bumps [com.github.spullara.mustache.java:compiler](https://github.com/spullara/mustache.java) from 0.9.13 to 0.9.14. - [Commits](spullara/mustache.java@mustache.java-0.9.13...mustache.java-0.9.14) --- updated-dependencies: - dependency-name: com.github.spullara.mustache.java:compiler dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * Bump net.minidev:accessors-smart from 2.5.0 to 2.5.1 in /plugins/repository-azure (#14673) * Bump net.minidev:accessors-smart in /plugins/repository-azure Bumps [net.minidev:accessors-smart](https://github.com/netplex/json-smart-v2) from 2.5.0 to 2.5.1. - [Release notes](https://github.com/netplex/json-smart-v2/releases) - [Commits](netplex/json-smart-v2@2.5.0...2.5.1) --- updated-dependencies: - dependency-name: net.minidev:accessors-smart dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * move query group thread context propagator out of ThreadContext Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: vatsal <[email protected]> Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: Sachin Kale <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: Vatsal <[email protected]> Co-authored-by: Siddhant Deshmukh <[email protected]> Co-authored-by: Robin Friedmann <[email protected]> Co-authored-by: rishavz_sagar <[email protected]> Co-authored-by: Sooraj Sinha <[email protected]> Co-authored-by: Sachin Kale <[email protected]> Co-authored-by: Craig Perkins <[email protected]> Co-authored-by: Bharathwaj G <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add consumers to remote store based index settings (#14764) Signed-off-by: Shourya Dutta Biswas <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add matchesPluginSystemIndexPattern to SystemIndexRegistry (#14750) * Add matchesPluginSystemIndexPattern to SystemIndexRegistry Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Use single data structure to keep track of system indices Signed-off-by: Craig Perkins <[email protected]> * Address code review comments Signed-off-by: Craig Perkins <[email protected]> * Add test for getAllDescriptors Signed-off-by: Craig Perkins <[email protected]> * Update server/src/main/java/org/opensearch/indices/SystemIndexRegistry.java Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * SPI for loading ABC templates (#14659) * SPI for loading ABC templates Signed-off-by: mgodwan <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix bulk upsert ignores the default_pipeline and final_pipeline when the auto-created index matches the index template (#12891) * Fix bulk upsert ignores the default_pipeline and final_pipeline when auto-created index matches with the index template Signed-off-by: Gao Binlong <[email protected]> * Modify changelog & comment Signed-off-by: Gao Binlong <[email protected]> * Use new approach Signed-off-by: Gao Binlong <[email protected]> * Fix test failure Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix flaky test due to node being used across all tests (#14787) Signed-off-by: Mohit Godwani <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Star Tree Implementation [OnHeap] (#14512) --------- Signed-off-by: Sarthak Aggarwal <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add Gao Binlong as maintainer (#14796) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Clear ehcache disk cache files during initialization (#14738) * Clear ehcache disk cache files during initialization Signed-off-by: Sagar Upadhyaya <[email protected]> * Adding UT to fix line coverage Signed-off-by: Sagar Upadhyaya <[email protected]> * Addressing comment Signed-off-by: Sagar Upadhyaya <[email protected]> * Adding more Uts for better line coverage Signed-off-by: Sagar Upadhyaya <[email protected]> * Throwing exception in case we fail to clear cache files during startup Signed-off-by: Sagar Upadhyaya <[email protected]> * Adding more UTs Signed-off-by: Sagar Upadhyaya <[email protected]> * Adding a UT for more coverage Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing gradle build Signed-off-by: Sagar Upadhyaya <[email protected]> * Update ehcache disk cache close() logic Signed-off-by: Sagar Upadhyaya <[email protected]> --------- Signed-off-by: Sagar Upadhyaya <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Refactor remote-routing-table service inline with remote state interfaces (#14668) --------- Signed-off-by: Arpit Bandejiya <[email protected]> Signed-off-by: Arpit-Bandejiya <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Set version to 2.15 for determining metadata during migration to remote store Signed-off-by: Sandeep Kumawat <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix bulk upsert ignores the default_pipeline and final_pipeline when the auto-created index matches the index template (#14793) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix create or update alias API doesn't throw exception for unsupported parameters (#14769) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Change RCSS info logs to debug (#14814) Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * [Bugfix] Fix NPE in ReplicaShardAllocator (#13993) (#14385) * [Bugfix] Fix NPE in ReplicaShardAllocator (#13993) Signed-off-by: Daniil Roman <[email protected]> * Add fix info to CHANGELOG.md Signed-off-by: Daniil Roman <[email protected]> --------- Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Run performance benchmark on pull requests (#14760) * add performance benchmark workflow for pull requests Signed-off-by: Rishabh Singh <[email protected]> * Update PERFORMANCE_BENCHMARKS.md Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> * Update PERFORMANCE_BENCHMARKS.md Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> * Update .github/workflows/benchmark-pull-request.yml Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> * Update .github/workflows/benchmark-pull-request.yml Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> * Update .github/workflows/benchmark-pull-request.yml Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> * Update .github/workflows/benchmark-pull-request.yml Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> --------- Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * fix constant_keyword field type (#14807) Signed-off-by: kkewwei <[email protected]> test Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * [Remote Store Migration] Reconcile remote store based index settings during STRICT mode switch (#14792) Signed-off-by: Shourya Dutta Biswas <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add prefix mode verification setting for repository verification (#14790) * Add prefix mode verification setting for repository verification Signed-off-by: Ashish Singh <[email protected]> * Add UTs and randomise prefix mode repository verification Signed-off-by: Ashish Singh <[email protected]> * Incorporate PR review feedback Signed-off-by: Ashish Singh <[email protected]> --------- Signed-off-by: Ashish Singh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * add length check on comment body for benchmark workflow (#14834) Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add restore-from-snapshot test procedure for snapshot run benchmark config (#14842) Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix env variable name typo (#14843) Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Use circuit breaker in InternalHistogram when adding empty buckets (#14754) * introduce circuit breaker in InternalHistogram Signed-off-by: bowenlan-amzn <[email protected]> * use circuit breaker from reduce context Signed-off-by: bowenlan-amzn <[email protected]> * add test Signed-off-by: bowenlan-amzn <[email protected]> * revert use_real_memory change in OpenSearchNode Signed-off-by: bowenlan-amzn <[email protected]> * add change log Signed-off-by: bowenlan-amzn <[email protected]> --------- Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * [Remote State] Create interface RemoteEntitiesManager (#14671) * Create interface RemoteEntitiesManager Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Optimise TransportNodesAction to not send DiscoveryNodes for NodeStat… (#14749) * Optimize TransportNodesAction to not send DiscoveryNodes for NodeStats, NodesInfo and ClusterStats call Signed-off-by: Pranshu Shukla <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Enabling term version check on local state for all ClusterManager Read Transport Actions (#14273) * enabling term version check on local state for all admin read actions Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Reduce logging in DEBUG for MasterService:run (#14795) * Reduce logging in DEBUG for MasteService:run by introducing short and long summary in Taskbatcher Signed-off-by: Sumit Bansal <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add SplitResponseProcessor to Search Pipelines (#14800) * Add SplitResponseProcessor for search pipelines Signed-off-by: Daniel Widdis <[email protected]> * Register the split processor factory Signed-off-by: Daniel Widdis <[email protected]> * Address code review comments Signed-off-by: Daniel Widdis <[email protected]> * Avoid list copy by casting array Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add integration tests for RemoteRoutingTable Service. (#14631) Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add SortResponseProcessor to Search Pipelines (#14785) * Add SortResponseProcessor for search pipelines Signed-off-by: Daniel Widdis <[email protected]> * Add stupid and unnecessary javadocs to satisfy overly strict CI Signed-off-by: Daniel Widdis <[email protected]> * Split casting and sorting methods for readability Signed-off-by: Daniel Widdis <[email protected]> * Register the sort processor factory Signed-off-by: Daniel Widdis <[email protected]> * Address code review comments Signed-off-by: Daniel Widdis <[email protected]> * Cast individual list elements to avoid creating two lists Signed-off-by: Daniel Widdis <[email protected]> * Add yamlRestTests Signed-off-by: Daniel Widdis <[email protected]> * Clarify why there's unusual sorting Signed-off-by: Daniel Widdis <[email protected]> * Use instanceof instead of isAssignableFrom Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix allowUnmappedFields, mapUnmappedFieldAsString settings to be applied when parsing query string query (#13957) * Modify to invoke QueryShardContext.fieldMapper() method to apply allowUnmappedFields and mapUnmappedFieldAsString settings Signed-off-by: imyp92 <[email protected]> * Add test cases to verify returning 400 responses if unmapped fields are included for some types of query Signed-off-by: imyp92 <[email protected]> * Add changelog Signed-off-by: imyp92 <[email protected]> --------- Signed-off-by: imyp92 <[email protected]> Signed-off-by: gaobinlong <[email protected]> Co-authored-by: gaobinlong <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump com.microsoft.azure:msal4j from 1.16.0 to 1.16.1 in /plugins/repository-azure (#14857) * Bump com.microsoft.azure:msal4j in /plugins/repository-azure Bumps [com.microsoft.azure:msal4j](https://github.com/AzureAD/microsoft-authentication-library-for-java) from 1.16.0 to 1.16.1. - [Release notes](https://github.com/AzureAD/microsoft-authentication-library-for-java/releases) - [Changelog](https://github.com/AzureAD/microsoft-authentication-library-for-java/blob/dev/changelog.txt) - [Commits](AzureAD/microsoft-authentication-library-for-java@v1.16.0...v1.16.1) --- updated-dependencies: - dependency-name: com.microsoft.azure:msal4j dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * Bump com.gradle.develocity from 3.17.5 to 3.17.6 (#14856) * Bump com.gradle.develocity from 3.17.5 to 3.17.6 Bumps com.gradle.develocity from 3.17.5 to 3.17.6. --- updated-dependencies: - dependency-name: com.gradle.develocity dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * Bump org.jline:jline in /test/fixtures/hdfs-fixture (#14859) Bumps [org.jline:jline](https://github.com/jline/jline3) from 3.26.2 to 3.26.3. - [Release notes](https://github.com/jline/jline3/releases) - [Changelog](https://github.com/jline/jline3/blob/master/changelog.md) - [Commits](jline/jline3@jline-parent-3.26.2...jline-parent-3.26.3) --- updated-dependencies: - dependency-name: org.jline:jline dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * Use Lucene provided Persian stem (#14847) Lucene provided Persian stem apparently isn't hooked yet and this change is doing that based on what is done for Arabic stem support. Signed-off-by: Ebrahim Byagowi <[email protected]> Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump actions/checkout from 2 to 4 (#14858) * Bump actions/checkout from 2 to 4 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * Deprecate batch_size parameter on bulk API (#14725) By default the full _bulk payload will be passed to ingest processors as a batch, with any sub batching logic to be implemented by each processor if necessary. Signed-off-by: Liyun Xiu <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add perms for remote snapshot cache eviction on scripted query (#14411) Signed-off-by: Finn Carroll <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * add transport interceptor to populate queryGroupId in task headers Signed-off-by: Kaushal Kumar <[email protected]> * Add rest, transport layer changes for Hot to warm tiering - dedicated setup (#13980) Signed-off-by: Neetika Singhal <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Create listener to refresh search thread resource usage (#14832) * [bug fix] fix incorrect coordinator node search resource usages Signed-off-by: Chenyang Ji <[email protected]> * fix bug on serialization when passing task resource usage to coordinator Signed-off-by: Chenyang Ji <[email protected]> * add more unit tests Signed-off-by: Chenyang Ji <[email protected]> * remove query insights plugin related code Signed-off-by: Chenyang Ji <[email protected]> * create per request listener to refresh task resource usage Signed-off-by: Chenyang Ji <[email protected]> * Make new listener API public Signed-off-by: Siddhant Deshmukh <[email protected]> * Add changelog Signed-off-by: Siddhant Deshmukh <[email protected]> * Remove wrong files added Signed-off-by: Siddhant Deshmukh <[email protected]> * Address review comments Signed-off-by: Siddhant Deshmukh <[email protected]> * Build fix Signed-off-by: Siddhant Deshmukh <[email protected]> * Make singleton Signed-off-by: Siddhant Deshmukh <[email protected]> * Address review comments Signed-off-by: Siddhant Deshmukh <[email protected]> * Make sure listener runs before plugin listeners Signed-off-by: Siddhant Deshmukh <[email protected]> * Spotless Signed-off-by: Siddhant Deshmukh <[email protected]> * Minor fix Signed-off-by: Siddhant Deshmukh <[email protected]> --------- Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: Jay Deng <[email protected]> Co-authored-by: Chenyang Ji <[email protected]> Co-authored-by: Jay Deng <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Caching avg total bytes and avg free bytes inside ClusterInfo (#14851) Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Use default value when index.number_of_replicas is null (#14812) * Use default value when index.number_of_replicas is null Signed-off-by: Liyun Xiu <[email protected]> * Add integration test Signed-off-by: Liyun Xiu <[email protected]> * Add changelog Signed-off-by: Liyun Xiu <[email protected]> --------- Signed-off-by: Liyun Xiu <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * [Remote Routing Table] Implement write and read flow for shard diff file. (#14684) * Implement write and read flow to upload/download shard diff file. Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Optimized ClusterStatsIndices to precomute shard stats (#14426) * Optimize Cluster Stats Indices to precomute node level stats Signed-off-by: Pranshu Shukla <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix constraint bug which allows more primary shards than average primary shards per index (#14908) Signed-off-by: Gaurav Bafna <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Optmising AwarenessAllocationDecider for hashmap.get call (#14761) Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * update comment Signed-off-by: Kaushal Kumar <[email protected]> * Fix IngestServiceTests.testBulkRequestExecutionWithFailures (#14918) The test would previously fail if the randomness led to only a single indexing request being included in the bulk payload. This change guarantees multiple indexing requests in order to ensure the batch logic kicks in. Also replace some unneeded mocks with real classes. Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * add queryGroupTask Signed-off-by: Kaushal Kumar <[email protected]> * remove unnecessary imports Signed-off-by: Kaushal Kumar <[email protected]> * add QueryGroupTask tests Signed-off-by: Kaushal Kumar <[email protected]> * rename WLM transport request handler Signed-off-by: Kaushal Kumar <[email protected]> * add CHANGELOG entry Signed-off-by: Kaushal Kumar <[email protected]> * fix ut Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * fix UT to remove the verify for final method Signed-off-by: Kaushal Kumar <[email protected]> * apply spotless Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]> Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Sandesh Kumar <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: Lukáš Vlček <[email protected]> Signed-off-by: kkewwei <[email protected]> Signed-off-by: Swetha Guptha <[email protected]> Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: ahmedsobeh <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: vatsal <[email protected]> Signed-off-by: Sachin Kale <[email protected]> Signed-off-by: Shourya Dutta Biswas <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: mgodwan <[email protected]> Signed-off-by: Mohit Godwani <[email protected]> Signed-off-by: Sagar Upadhyaya <[email protected]> Signed-off-by: Sandeep Kumawat <[email protected]> Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: Ashish Singh <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: Pranshu Shukla <[email protected]> Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]> Signed-off-by: Sumit Bansal <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: imyp92 <[email protected]> Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Ebrahim Byagowi <[email protected]> Signed-off-by: Liyun Xiu <[email protected]> Signed-off-by: Finn Carroll <[email protected]> Signed-off-by: Neetika Singhal <[email protected]> Signed-off-by: Jay Deng <[email protected]> Signed-off-by: Gaurav Bafna <[email protected]> Signed-off-by: Andrew Ross <[email protected]> Co-authored-by: Shivansh Arora <[email protected]> Co-authored-by: Arpit-Bandejiya <[email protected]> Co-authored-by: gaobinlong <[email protected]> Co-authored-by: rishavz_sagar <[email protected]> Co-authored-by: Chenyang Ji <[email protected]> Co-authored-by: Craig Perkins <[email protected]> Co-authored-by: Sandesh Kumar <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Co-authored-by: Zelin Hao <[email protected]> Co-authored-by: Lukáš Vlček <[email protected]> Co-authored-by: kkewwei <[email protected]> Co-authored-by: SwethaGuptha <[email protected]> Co-authored-by: Sooraj Sinha <[email protected]> Co-authored-by: Ahmed Sobeh <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Siddhant Deshmukh <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: Vatsal <[email protected]> Co-authored-by: Robin Friedmann <[email protected]> Co-authored-by: Sachin Kale <[email protected]> Co-authored-by: Bharathwaj G <[email protected]> Co-authored-by: Shourya Dutta Biswas <[email protected]> Co-authored-by: Craig Perkins <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Co-authored-by: Mohit Godwani <[email protected]> Co-authored-by: Sarthak Aggarwal <[email protected]> Co-authored-by: Sagar <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]> Co-authored-by: Daniil Roman <[email protected]> Co-authored-by: Rishabh Singh <[email protected]> Co-authored-by: kkewwei <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Ashish Singh <[email protected]> Co-authored-by: bowenlan-amzn <[email protected]> Co-authored-by: Pranshu Shukla <[email protected]> Co-authored-by: rajiv-kv <[email protected]> Co-authored-by: Sumit Bansal <[email protected]> Co-authored-by: Daniel Widdis <[email protected]> Co-authored-by: shailendra0811 <[email protected]> Co-authored-by: Park, Yeongwu <[email protected]> Co-authored-by: ebraminio <[email protected]> Co-authored-by: Liyun Xiu <[email protected]> Co-authored-by: Finn <[email protected]> Co-authored-by: Neetika Singhal <[email protected]> Co-authored-by: Jay Deng <[email protected]> Co-authored-by: Gaurav Bafna <[email protected]> Co-authored-by: Andrew Ross <[email protected]>
opensearch-trigger-bot bot
added a commit
that referenced
this pull request
Jul 30, 2024
…de level (#14708) * add logic to add headers to Task Signed-off-by: Kaushal Kumar <[email protected]> * add logic to add queryGroupId to task headers Signed-off-by: Kaushal Kumar <[email protected]> * remove redundant code Signed-off-by: Kaushal Kumar <[email protected]> * add changelog entry Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * fix precommit Signed-off-by: Kaushal Kumar <[email protected]> * Add UTs for RemoteIndexMetadataManager (#14660) Signed-off-by: Shivansh Arora <[email protected]> Co-authored-by: Arpit-Bandejiya <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix match_phrase_prefix_query not working on text field with multiple values and index_prefixes (#10959) * Fix match_phrase_prefix_query not working on text field with multiple values and index_prefixes Signed-off-by: Gao Binlong <[email protected]> * Add more test Signed-off-by: Gao Binlong <[email protected]> * modify change log Signed-off-by: Gao Binlong <[email protected]> * Fix test failure Signed-off-by: Gao Binlong <[email protected]> * Change the indexAnalyzer used by prefix field Signed-off-by: Gao Binlong <[email protected]> * Skip old version for yaml test Signed-off-by: Gao Binlong <[email protected]> * Optimize some code Signed-off-by: Gao Binlong <[email protected]> * Fix test failure Signed-off-by: Gao Binlong <[email protected]> * Modify yaml test description Signed-off-by: Gao Binlong <[email protected]> * Remove the name parameter for setAnalyzer() Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Offline calculation of total shard per node and caching it for weight calculation inside LocalShardBalancer (#14675) Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * [bug fix] validate lower bound for top n size (#14587) Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Create SystemIndexRegistry with helper method matchesSystemIndex (#14415) * Create new extension point in SystemIndexPlugin for a single plugin to get registered system indices Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * WIP on system indices from IndexNameExpressionResolver Signed-off-by: Craig Perkins <[email protected]> * Add test in IndexNameExpressionResolverTests Signed-off-by: Craig Perkins <[email protected]> * Remove changes in SystemIndexPlugin Signed-off-by: Craig Perkins <[email protected]> * Add method in IndexNameExpressionResolver to get matching system indices Signed-off-by: Craig Perkins <[email protected]> * Show how resolver can be chained to get system indices Signed-off-by: Craig Perkins <[email protected]> * Fix forbiddenApis check Signed-off-by: Craig Perkins <[email protected]> * Update CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Make SystemIndices internal Signed-off-by: Craig Perkins <[email protected]> * Remove unneeded changes Signed-off-by: Craig Perkins <[email protected]> * Fix CI failures Signed-off-by: Craig Perkins <[email protected]> * Fix precommit errors Signed-off-by: Craig Perkins <[email protected]> * Use Regex instead of WildcardMatcher Signed-off-by: Craig Perkins <[email protected]> * Address code review feedback Signed-off-by: Craig Perkins <[email protected]> * Allow caller to pass index expressions Signed-off-by: Craig Perkins <[email protected]> * Create SystemIndexRegistry Signed-off-by: Craig Perkins <[email protected]> * Update CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Remove singleton limitation Signed-off-by: Craig Perkins <[email protected]> * Add javadoc Signed-off-by: Craig Perkins <[email protected]> * Add @experimentalapi annotation Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Refactor Grok validate pattern to iterative approach (#14206) * grok validate patterns recusrion to iterative Signed-off-by: Sandesh Kumar <[email protected]> * Add max depth in resolving a pattern to avoid OOM Signed-off-by: Sandesh Kumar <[email protected]> * change path from deque to arraylist Signed-off-by: Sandesh Kumar <[email protected]> * rename queue to stack Signed-off-by: Sandesh Kumar <[email protected]> * Change max depth to 500 Signed-off-by: Sandesh Kumar <[email protected]> * typo originPatternName fix Signed-off-by: Sandesh Kumar <[email protected]> * spotless Signed-off-by: Sandesh Kumar <[email protected]> --------- Signed-off-by: Sandesh Kumar <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump opentelemetry from 1.39.0 to 1.40.0 (#14674) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump jackson from 2.17.1 to 2.17.2 (#14687) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add release notes for release 1.3.18 (#14699) Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump reactor from 3.5.19 to 3.5.20 (#14697) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add unit tests for read flow of RemoteClusterStateService and bug fix for transient settings (#14476) Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Update version check for the bug fix of match_phrase_prefix_query not working on text field with multiple values and index_prefixes (#14703) Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Remove unnecessary cast to int from test (#14696) Signed-off-by: Lukáš Vlček <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * print reason why parent task was cancelled (#14604) Signed-off-by: kkewwei <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Use set of shard routing for shard in unassigned shard batch check. (#14533) Signed-off-by: Swetha Guptha <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add versioning for UploadedIndexMetadata (#14677) * Add versioning for UploadedIndexMetadata * Handle componentPrefix for backward compatibility Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix: update help output for _cat (#14722) * fixed help output for _cat Signed-off-by: ahmedsobeh <[email protected]> * updated changelog Signed-off-by: ahmedsobeh <[email protected]> * updated changelog Signed-off-by: ahmedsobeh <[email protected]> --------- Signed-off-by: ahmedsobeh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix hdfs-fixture kerb-admin & hadoop-minicluster dependencies are not being updated / false positive reports on CVEs (#14729) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Update to Gradle 8.9 (#14574) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix hdfs-fixture hadoop-minicluster dependencies are not being updated / false positive reports on CVEs (#14732) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add `strict_allow_templates` dynamic mapping option (#14555) * The dynamic mapping parameter supports strict_allow_templates Signed-off-by: Gao Binlong <[email protected]> * Modify change log Signed-off-by: Gao Binlong <[email protected]> * Modify skip version in yml test file Signed-off-by: Gao Binlong <[email protected]> * Refactor some code Signed-off-by: Gao Binlong <[email protected]> * Keep the old methods Signed-off-by: Gao Binlong <[email protected]> * change public to private Signed-off-by: Gao Binlong <[email protected]> * Optimize some code Signed-off-by: Gao Binlong <[email protected]> * Do not override toString method for Dynamic Signed-off-by: Gao Binlong <[email protected]> * Optimize some code and modify the changelog Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump net.minidev:json-smart from 2.5.0 to 2.5.1 in /plugins/repository-azure (#14748) * Bump net.minidev:json-smart in /plugins/repository-azure Bumps [net.minidev:json-smart](https://github.com/netplex/json-smart-v2) from 2.5.0 to 2.5.1. - [Release notes](https://github.com/netplex/json-smart-v2/releases) - [Commits](netplex/json-smart-v2@2.5.0...2.5.1) --- updated-dependencies: - dependency-name: net.minidev:json-smart dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * remove query insights plugin from core (#14743) Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add `strict_allow_templates` dynamic mapping option (#14555) (#14737) (#14742) * The dynamic mapping parameter supports strict_allow_templates * Modify change log * Modify skip version in yml test file * Refactor some code * Keep the old methods * change public to private * Optimize some code * Do not override toString method for Dynamic * Optimize some code and modify the changelog --------- (cherry picked from commit 6b8b3ef) Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * Fix create or update alias API doesn't throw exception for unsupported parameters (#14719) * Fix create or update alias API doesn't throw exception for unsupported parameters Signed-off-by: Gao Binlong <[email protected]> * Update version check in yml test Signed-off-by: Gao Binlong <[email protected]> * modify change log Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Remove query categorization from core (#14759) * Remove query categorization from core Signed-off-by: Siddhant Deshmukh <[email protected]> * Add changelog Signed-off-by: Siddhant Deshmukh <[email protected]> * Trigger Build Signed-off-by: Siddhant Deshmukh <[email protected]> --------- Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add changes to propagate queryGroupId across child requests and nodes (#14614) * add query group header propagator Signed-off-by: Kaushal Kumar <[email protected]> * apply spotless check Signed-off-by: Kaushal Kumar <[email protected]> * add new propagator in ThreadContext Signed-off-by: Kaushal Kumar <[email protected]> * spotlessApply Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * Bump com.microsoft.azure:msal4j from 1.15.1 to 1.16.0 in /plugins/repository-azure (#14610) * Bump com.microsoft.azure:msal4j in /plugins/repository-azure Bumps [com.microsoft.azure:msal4j](https://github.com/AzureAD/microsoft-authentication-library-for-java) from 1.15.1 to 1.16.0. - [Release notes](https://github.com/AzureAD/microsoft-authentication-library-for-java/releases) - [Changelog](https://github.com/AzureAD/microsoft-authentication-library-for-java/blob/dev/changelog.txt) - [Commits](AzureAD/microsoft-authentication-library-for-java@v1.15.1...v1.16.0) --- updated-dependencies: - dependency-name: com.microsoft.azure:msal4j dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * [Bugfix] Fix ICacheKeySerializerTests flakiness (#14564) * Fix testInvalidInput flakiness Signed-off-by: Peter Alfonsi <[email protected]> * Addressed andrross's comment Signed-off-by: Peter Alfonsi <[email protected]> * rerun security check Signed-off-by: Peter Alfonsi <[email protected]> --------- Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Correct typo in method name (#14621) Signed-off-by: vatsal <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Refactoring FilterPath.parse by using an iterative approach instead of recursion. (#14200) * Refactor FilterPath parse function (#12067) Signed-off-by: Robin Friedmann <[email protected]> * Implement unit tests for FilterPathTests (#12067) Signed-off-by: Robin Friedmann <[email protected]> * Write warn log if Filter is empty; Add comments (#12067) Signed-off-by: Robin Friedmann <[email protected]> * Add changelog Signed-off-by: Siddhant Deshmukh <[email protected]> * Remove unnecessary log statement Signed-off-by: Siddhant Deshmukh <[email protected]> * Remove unused logger Signed-off-by: Siddhant Deshmukh <[email protected]> * Spotless apply Signed-off-by: Siddhant Deshmukh <[email protected]> * Remove incorrect changelog Signed-off-by: Siddhant Deshmukh <[email protected]> --------- Signed-off-by: Siddhant Deshmukh <[email protected]> Co-authored-by: Robin Friedmann <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Removing String format in RemoteStoreMigrationAllocationDecider to optimise performance(#14612) Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Clear templates before Adding; Use NamedWriteableAwareStreamInput for RemoteCustomMetadata; Correct the check for deciding upload of HashesOfConsistentSettings (#14513) * Clear templates before Adding; Use NamedWriteableAwareStreamInput for RemoteCustomMetadata * Correct the check for deciding upload of hashes of consistent settings Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * add changelog Signed-off-by: Kaushal Kumar <[email protected]> * add PR link changelog Signed-off-by: Kaushal Kumar <[email protected]> * Improve reroute performance by optimising List.removeAll in LocalShardsBalancer to filter remote search shard from relocation decision (#14613) Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix assertion failure while deleting remote backed index (#14601) Signed-off-by: Sachin Kale <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Allow system index warning in OpenSearchRestTestCase.refreshAllIndices (#14635) * Allow system index warning Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Address code review comments Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Star tree codec changes (#14514) --------- Signed-off-by: Bharathwaj G <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump com.github.spullara.mustache.java:compiler from 0.9.13 to 0.9.14 in /modules/lang-mustache (#14672) * Bump com.github.spullara.mustache.java:compiler Bumps [com.github.spullara.mustache.java:compiler](https://github.com/spullara/mustache.java) from 0.9.13 to 0.9.14. - [Commits](spullara/mustache.java@mustache.java-0.9.13...mustache.java-0.9.14) --- updated-dependencies: - dependency-name: com.github.spullara.mustache.java:compiler dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * Bump net.minidev:accessors-smart from 2.5.0 to 2.5.1 in /plugins/repository-azure (#14673) * Bump net.minidev:accessors-smart in /plugins/repository-azure Bumps [net.minidev:accessors-smart](https://github.com/netplex/json-smart-v2) from 2.5.0 to 2.5.1. - [Release notes](https://github.com/netplex/json-smart-v2/releases) - [Commits](netplex/json-smart-v2@2.5.0...2.5.1) --- updated-dependencies: - dependency-name: net.minidev:accessors-smart dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * move query group thread context propagator out of ThreadContext Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: vatsal <[email protected]> Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: Sachin Kale <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: Vatsal <[email protected]> Co-authored-by: Siddhant Deshmukh <[email protected]> Co-authored-by: Robin Friedmann <[email protected]> Co-authored-by: rishavz_sagar <[email protected]> Co-authored-by: Sooraj Sinha <[email protected]> Co-authored-by: Sachin Kale <[email protected]> Co-authored-by: Craig Perkins <[email protected]> Co-authored-by: Bharathwaj G <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add consumers to remote store based index settings (#14764) Signed-off-by: Shourya Dutta Biswas <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add matchesPluginSystemIndexPattern to SystemIndexRegistry (#14750) * Add matchesPluginSystemIndexPattern to SystemIndexRegistry Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Use single data structure to keep track of system indices Signed-off-by: Craig Perkins <[email protected]> * Address code review comments Signed-off-by: Craig Perkins <[email protected]> * Add test for getAllDescriptors Signed-off-by: Craig Perkins <[email protected]> * Update server/src/main/java/org/opensearch/indices/SystemIndexRegistry.java Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * SPI for loading ABC templates (#14659) * SPI for loading ABC templates Signed-off-by: mgodwan <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix bulk upsert ignores the default_pipeline and final_pipeline when the auto-created index matches the index template (#12891) * Fix bulk upsert ignores the default_pipeline and final_pipeline when auto-created index matches with the index template Signed-off-by: Gao Binlong <[email protected]> * Modify changelog & comment Signed-off-by: Gao Binlong <[email protected]> * Use new approach Signed-off-by: Gao Binlong <[email protected]> * Fix test failure Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix flaky test due to node being used across all tests (#14787) Signed-off-by: Mohit Godwani <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Star Tree Implementation [OnHeap] (#14512) --------- Signed-off-by: Sarthak Aggarwal <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add Gao Binlong as maintainer (#14796) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Clear ehcache disk cache files during initialization (#14738) * Clear ehcache disk cache files during initialization Signed-off-by: Sagar Upadhyaya <[email protected]> * Adding UT to fix line coverage Signed-off-by: Sagar Upadhyaya <[email protected]> * Addressing comment Signed-off-by: Sagar Upadhyaya <[email protected]> * Adding more Uts for better line coverage Signed-off-by: Sagar Upadhyaya <[email protected]> * Throwing exception in case we fail to clear cache files during startup Signed-off-by: Sagar Upadhyaya <[email protected]> * Adding more UTs Signed-off-by: Sagar Upadhyaya <[email protected]> * Adding a UT for more coverage Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing gradle build Signed-off-by: Sagar Upadhyaya <[email protected]> * Update ehcache disk cache close() logic Signed-off-by: Sagar Upadhyaya <[email protected]> --------- Signed-off-by: Sagar Upadhyaya <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Refactor remote-routing-table service inline with remote state interfaces (#14668) --------- Signed-off-by: Arpit Bandejiya <[email protected]> Signed-off-by: Arpit-Bandejiya <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Set version to 2.15 for determining metadata during migration to remote store Signed-off-by: Sandeep Kumawat <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix bulk upsert ignores the default_pipeline and final_pipeline when the auto-created index matches the index template (#14793) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix create or update alias API doesn't throw exception for unsupported parameters (#14769) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Change RCSS info logs to debug (#14814) Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * [Bugfix] Fix NPE in ReplicaShardAllocator (#13993) (#14385) * [Bugfix] Fix NPE in ReplicaShardAllocator (#13993) Signed-off-by: Daniil Roman <[email protected]> * Add fix info to CHANGELOG.md Signed-off-by: Daniil Roman <[email protected]> --------- Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Run performance benchmark on pull requests (#14760) * add performance benchmark workflow for pull requests Signed-off-by: Rishabh Singh <[email protected]> * Update PERFORMANCE_BENCHMARKS.md Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> * Update PERFORMANCE_BENCHMARKS.md Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> * Update .github/workflows/benchmark-pull-request.yml Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> * Update .github/workflows/benchmark-pull-request.yml Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> * Update .github/workflows/benchmark-pull-request.yml Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> * Update .github/workflows/benchmark-pull-request.yml Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> --------- Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * fix constant_keyword field type (#14807) Signed-off-by: kkewwei <[email protected]> test Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * [Remote Store Migration] Reconcile remote store based index settings during STRICT mode switch (#14792) Signed-off-by: Shourya Dutta Biswas <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add prefix mode verification setting for repository verification (#14790) * Add prefix mode verification setting for repository verification Signed-off-by: Ashish Singh <[email protected]> * Add UTs and randomise prefix mode repository verification Signed-off-by: Ashish Singh <[email protected]> * Incorporate PR review feedback Signed-off-by: Ashish Singh <[email protected]> --------- Signed-off-by: Ashish Singh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * add length check on comment body for benchmark workflow (#14834) Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add restore-from-snapshot test procedure for snapshot run benchmark config (#14842) Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix env variable name typo (#14843) Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Use circuit breaker in InternalHistogram when adding empty buckets (#14754) * introduce circuit breaker in InternalHistogram Signed-off-by: bowenlan-amzn <[email protected]> * use circuit breaker from reduce context Signed-off-by: bowenlan-amzn <[email protected]> * add test Signed-off-by: bowenlan-amzn <[email protected]> * revert use_real_memory change in OpenSearchNode Signed-off-by: bowenlan-amzn <[email protected]> * add change log Signed-off-by: bowenlan-amzn <[email protected]> --------- Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * [Remote State] Create interface RemoteEntitiesManager (#14671) * Create interface RemoteEntitiesManager Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Optimise TransportNodesAction to not send DiscoveryNodes for NodeStat… (#14749) * Optimize TransportNodesAction to not send DiscoveryNodes for NodeStats, NodesInfo and ClusterStats call Signed-off-by: Pranshu Shukla <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Enabling term version check on local state for all ClusterManager Read Transport Actions (#14273) * enabling term version check on local state for all admin read actions Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Reduce logging in DEBUG for MasterService:run (#14795) * Reduce logging in DEBUG for MasteService:run by introducing short and long summary in Taskbatcher Signed-off-by: Sumit Bansal <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add SplitResponseProcessor to Search Pipelines (#14800) * Add SplitResponseProcessor for search pipelines Signed-off-by: Daniel Widdis <[email protected]> * Register the split processor factory Signed-off-by: Daniel Widdis <[email protected]> * Address code review comments Signed-off-by: Daniel Widdis <[email protected]> * Avoid list copy by casting array Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add integration tests for RemoteRoutingTable Service. (#14631) Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add SortResponseProcessor to Search Pipelines (#14785) * Add SortResponseProcessor for search pipelines Signed-off-by: Daniel Widdis <[email protected]> * Add stupid and unnecessary javadocs to satisfy overly strict CI Signed-off-by: Daniel Widdis <[email protected]> * Split casting and sorting methods for readability Signed-off-by: Daniel Widdis <[email protected]> * Register the sort processor factory Signed-off-by: Daniel Widdis <[email protected]> * Address code review comments Signed-off-by: Daniel Widdis <[email protected]> * Cast individual list elements to avoid creating two lists Signed-off-by: Daniel Widdis <[email protected]> * Add yamlRestTests Signed-off-by: Daniel Widdis <[email protected]> * Clarify why there's unusual sorting Signed-off-by: Daniel Widdis <[email protected]> * Use instanceof instead of isAssignableFrom Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix allowUnmappedFields, mapUnmappedFieldAsString settings to be applied when parsing query string query (#13957) * Modify to invoke QueryShardContext.fieldMapper() method to apply allowUnmappedFields and mapUnmappedFieldAsString settings Signed-off-by: imyp92 <[email protected]> * Add test cases to verify returning 400 responses if unmapped fields are included for some types of query Signed-off-by: imyp92 <[email protected]> * Add changelog Signed-off-by: imyp92 <[email protected]> --------- Signed-off-by: imyp92 <[email protected]> Signed-off-by: gaobinlong <[email protected]> Co-authored-by: gaobinlong <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump com.microsoft.azure:msal4j from 1.16.0 to 1.16.1 in /plugins/repository-azure (#14857) * Bump com.microsoft.azure:msal4j in /plugins/repository-azure Bumps [com.microsoft.azure:msal4j](https://github.com/AzureAD/microsoft-authentication-library-for-java) from 1.16.0 to 1.16.1. - [Release notes](https://github.com/AzureAD/microsoft-authentication-library-for-java/releases) - [Changelog](https://github.com/AzureAD/microsoft-authentication-library-for-java/blob/dev/changelog.txt) - [Commits](AzureAD/microsoft-authentication-library-for-java@v1.16.0...v1.16.1) --- updated-dependencies: - dependency-name: com.microsoft.azure:msal4j dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * Bump com.gradle.develocity from 3.17.5 to 3.17.6 (#14856) * Bump com.gradle.develocity from 3.17.5 to 3.17.6 Bumps com.gradle.develocity from 3.17.5 to 3.17.6. --- updated-dependencies: - dependency-name: com.gradle.develocity dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * Bump org.jline:jline in /test/fixtures/hdfs-fixture (#14859) Bumps [org.jline:jline](https://github.com/jline/jline3) from 3.26.2 to 3.26.3. - [Release notes](https://github.com/jline/jline3/releases) - [Changelog](https://github.com/jline/jline3/blob/master/changelog.md) - [Commits](jline/jline3@jline-parent-3.26.2...jline-parent-3.26.3) --- updated-dependencies: - dependency-name: org.jline:jline dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * Use Lucene provided Persian stem (#14847) Lucene provided Persian stem apparently isn't hooked yet and this change is doing that based on what is done for Arabic stem support. Signed-off-by: Ebrahim Byagowi <[email protected]> Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump actions/checkout from 2 to 4 (#14858) * Bump actions/checkout from 2 to 4 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * Deprecate batch_size parameter on bulk API (#14725) By default the full _bulk payload will be passed to ingest processors as a batch, with any sub batching logic to be implemented by each processor if necessary. Signed-off-by: Liyun Xiu <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add perms for remote snapshot cache eviction on scripted query (#14411) Signed-off-by: Finn Carroll <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * add transport interceptor to populate queryGroupId in task headers Signed-off-by: Kaushal Kumar <[email protected]> * Add rest, transport layer changes for Hot to warm tiering - dedicated setup (#13980) Signed-off-by: Neetika Singhal <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Create listener to refresh search thread resource usage (#14832) * [bug fix] fix incorrect coordinator node search resource usages Signed-off-by: Chenyang Ji <[email protected]> * fix bug on serialization when passing task resource usage to coordinator Signed-off-by: Chenyang Ji <[email protected]> * add more unit tests Signed-off-by: Chenyang Ji <[email protected]> * remove query insights plugin related code Signed-off-by: Chenyang Ji <[email protected]> * create per request listener to refresh task resource usage Signed-off-by: Chenyang Ji <[email protected]> * Make new listener API public Signed-off-by: Siddhant Deshmukh <[email protected]> * Add changelog Signed-off-by: Siddhant Deshmukh <[email protected]> * Remove wrong files added Signed-off-by: Siddhant Deshmukh <[email protected]> * Address review comments Signed-off-by: Siddhant Deshmukh <[email protected]> * Build fix Signed-off-by: Siddhant Deshmukh <[email protected]> * Make singleton Signed-off-by: Siddhant Deshmukh <[email protected]> * Address review comments Signed-off-by: Siddhant Deshmukh <[email protected]> * Make sure listener runs before plugin listeners Signed-off-by: Siddhant Deshmukh <[email protected]> * Spotless Signed-off-by: Siddhant Deshmukh <[email protected]> * Minor fix Signed-off-by: Siddhant Deshmukh <[email protected]> --------- Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: Jay Deng <[email protected]> Co-authored-by: Chenyang Ji <[email protected]> Co-authored-by: Jay Deng <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Caching avg total bytes and avg free bytes inside ClusterInfo (#14851) Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Use default value when index.number_of_replicas is null (#14812) * Use default value when index.number_of_replicas is null Signed-off-by: Liyun Xiu <[email protected]> * Add integration test Signed-off-by: Liyun Xiu <[email protected]> * Add changelog Signed-off-by: Liyun Xiu <[email protected]> --------- Signed-off-by: Liyun Xiu <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * [Remote Routing Table] Implement write and read flow for shard diff file. (#14684) * Implement write and read flow to upload/download shard diff file. Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Optimized ClusterStatsIndices to precomute shard stats (#14426) * Optimize Cluster Stats Indices to precomute node level stats Signed-off-by: Pranshu Shukla <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix constraint bug which allows more primary shards than average primary shards per index (#14908) Signed-off-by: Gaurav Bafna <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Optmising AwarenessAllocationDecider for hashmap.get call (#14761) Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * update comment Signed-off-by: Kaushal Kumar <[email protected]> * Fix IngestServiceTests.testBulkRequestExecutionWithFailures (#14918) The test would previously fail if the randomness led to only a single indexing request being included in the bulk payload. This change guarantees multiple indexing requests in order to ensure the batch logic kicks in. Also replace some unneeded mocks with real classes. Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * add queryGroupTask Signed-off-by: Kaushal Kumar <[email protected]> * remove unnecessary imports Signed-off-by: Kaushal Kumar <[email protected]> * add QueryGroupTask tests Signed-off-by: Kaushal Kumar <[email protected]> * rename WLM transport request handler Signed-off-by: Kaushal Kumar <[email protected]> * add CHANGELOG entry Signed-off-by: Kaushal Kumar <[email protected]> * fix ut Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * fix UT to remove the verify for final method Signed-off-by: Kaushal Kumar <[email protected]> * apply spotless Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]> Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Sandesh Kumar <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: Lukáš Vlček <[email protected]> Signed-off-by: kkewwei <[email protected]> Signed-off-by: Swetha Guptha <[email protected]> Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: ahmedsobeh <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: vatsal <[email protected]> Signed-off-by: Sachin Kale <[email protected]> Signed-off-by: Shourya Dutta Biswas <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: mgodwan <[email protected]> Signed-off-by: Mohit Godwani <[email protected]> Signed-off-by: Sagar Upadhyaya <[email protected]> Signed-off-by: Sandeep Kumawat <[email protected]> Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: Ashish Singh <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: Pranshu Shukla <[email protected]> Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]> Signed-off-by: Sumit Bansal <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: imyp92 <[email protected]> Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Ebrahim Byagowi <[email protected]> Signed-off-by: Liyun Xiu <[email protected]> Signed-off-by: Finn Carroll <[email protected]> Signed-off-by: Neetika Singhal <[email protected]> Signed-off-by: Jay Deng <[email protected]> Signed-off-by: Gaurav Bafna <[email protected]> Signed-off-by: Andrew Ross <[email protected]> Co-authored-by: Shivansh Arora <[email protected]> Co-authored-by: Arpit-Bandejiya <[email protected]> Co-authored-by: gaobinlong <[email protected]> Co-authored-by: rishavz_sagar <[email protected]> Co-authored-by: Chenyang Ji <[email protected]> Co-authored-by: Craig Perkins <[email protected]> Co-authored-by: Sandesh Kumar <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Co-authored-by: Zelin Hao <[email protected]> Co-authored-by: Lukáš Vlček <[email protected]> Co-authored-by: kkewwei <[email protected]> Co-authored-by: SwethaGuptha <[email protected]> Co-authored-by: Sooraj Sinha <[email protected]> Co-authored-by: Ahmed Sobeh <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Siddhant Deshmukh <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: Vatsal <[email protected]> Co-authored-by: Robin Friedmann <[email protected]> Co-authored-by: Sachin Kale <[email protected]> Co-authored-by: Bharathwaj G <[email protected]> Co-authored-by: Shourya Dutta Biswas <[email protected]> Co-authored-by: Craig Perkins <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Co-authored-by: Mohit Godwani <[email protected]> Co-authored-by: Sarthak Aggarwal <[email protected]> Co-authored-by: Sagar <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]> Co-authored-by: Daniil Roman <[email protected]> Co-authored-by: Rishabh Singh <[email protected]> Co-authored-by: kkewwei <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Ashish Singh <[email protected]> Co-authored-by: bowenlan-amzn <[email protected]> Co-authored-by: Pranshu Shukla <[email protected]> Co-authored-by: rajiv-kv <[email protected]> Co-authored-by: Sumit Bansal <[email protected]> Co-authored-by: Daniel Widdis <[email protected]> Co-authored-by: shailendra0811 <[email protected]> Co-authored-by: Park, Yeongwu <[email protected]> Co-authored-by: ebraminio <[email protected]> Co-authored-by: Liyun Xiu <[email protected]> Co-authored-by: Finn <[email protected]> Co-authored-by: Neetika Singhal <[email protected]> Co-authored-by: Jay Deng <[email protected]> Co-authored-by: Gaurav Bafna <[email protected]> Co-authored-by: Andrew Ross <[email protected]> (cherry picked from commit eb306d2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jed326
added a commit
that referenced
this pull request
Aug 7, 2024
…de level (#14708) (#15029) * add logic to add headers to Task * add logic to add queryGroupId to task headers * remove redundant code * add changelog entry * address comments * fix precommit * Add UTs for RemoteIndexMetadataManager (#14660) * Fix match_phrase_prefix_query not working on text field with multiple values and index_prefixes (#10959) * Fix match_phrase_prefix_query not working on text field with multiple values and index_prefixes * Add more test * modify change log * Fix test failure * Change the indexAnalyzer used by prefix field * Skip old version for yaml test * Optimize some code * Fix test failure * Modify yaml test description * Remove the name parameter for setAnalyzer() --------- * Offline calculation of total shard per node and caching it for weight calculation inside LocalShardBalancer (#14675) * [bug fix] validate lower bound for top n size (#14587) * Create SystemIndexRegistry with helper method matchesSystemIndex (#14415) * Create new extension point in SystemIndexPlugin for a single plugin to get registered system indices * Add to CHANGELOG * WIP on system indices from IndexNameExpressionResolver * Add test in IndexNameExpressionResolverTests * Remove changes in SystemIndexPlugin * Add method in IndexNameExpressionResolver to get matching system indices * Show how resolver can be chained to get system indices * Fix forbiddenApis check * Update CHANGELOG * Make SystemIndices internal * Remove unneeded changes * Fix CI failures * Fix precommit errors * Use Regex instead of WildcardMatcher * Address code review feedback * Allow caller to pass index expressions * Create SystemIndexRegistry * Update CHANGELOG * Remove singleton limitation * Add javadoc * Add @experimentalapi annotation --------- * Refactor Grok validate pattern to iterative approach (#14206) * grok validate patterns recusrion to iterative * Add max depth in resolving a pattern to avoid OOM * change path from deque to arraylist * rename queue to stack * Change max depth to 500 * typo originPatternName fix * spotless --------- * Bump opentelemetry from 1.39.0 to 1.40.0 (#14674) * Bump jackson from 2.17.1 to 2.17.2 (#14687) * Add release notes for release 1.3.18 (#14699) * Bump reactor from 3.5.19 to 3.5.20 (#14697) * Add unit tests for read flow of RemoteClusterStateService and bug fix for transient settings (#14476) * Update version check for the bug fix of match_phrase_prefix_query not working on text field with multiple values and index_prefixes (#14703) * Remove unnecessary cast to int from test (#14696) * print reason why parent task was cancelled (#14604) * Use set of shard routing for shard in unassigned shard batch check. (#14533) * Add versioning for UploadedIndexMetadata (#14677) * Add versioning for UploadedIndexMetadata * Handle componentPrefix for backward compatibility * Fix: update help output for _cat (#14722) * fixed help output for _cat * updated changelog * updated changelog --------- * Fix hdfs-fixture kerb-admin & hadoop-minicluster dependencies are not being updated / false positive reports on CVEs (#14729) * Update to Gradle 8.9 (#14574) * Fix hdfs-fixture hadoop-minicluster dependencies are not being updated / false positive reports on CVEs (#14732) * Add `strict_allow_templates` dynamic mapping option (#14555) * The dynamic mapping parameter supports strict_allow_templates * Modify change log * Modify skip version in yml test file * Refactor some code * Keep the old methods * change public to private * Optimize some code * Do not override toString method for Dynamic * Optimize some code and modify the changelog --------- * Bump net.minidev:json-smart from 2.5.0 to 2.5.1 in /plugins/repository-azure (#14748) * Bump net.minidev:json-smart in /plugins/repository-azure Bumps [net.minidev:json-smart](https://github.com/netplex/json-smart-v2) from 2.5.0 to 2.5.1. - [Release notes](https://github.com/netplex/json-smart-v2/releases) - [Commits](netplex/json-smart-v2@2.5.0...2.5.1) --- updated-dependencies: - dependency-name: net.minidev:json-smart dependency-type: direct:production update-type: version-update:semver-patch ... * Updating SHAs * Update changelog --------- * remove query insights plugin from core (#14743) * Add `strict_allow_templates` dynamic mapping option (#14555) (#14737) (#14742) * The dynamic mapping parameter supports strict_allow_templates * Modify change log * Modify skip version in yml test file * Refactor some code * Keep the old methods * change public to private * Optimize some code * Do not override toString method for Dynamic * Optimize some code and modify the changelog --------- (cherry picked from commit 6b8b3ef) * Fix create or update alias API doesn't throw exception for unsupported parameters (#14719) * Fix create or update alias API doesn't throw exception for unsupported parameters * Update version check in yml test * modify change log --------- * Remove query categorization from core (#14759) * Remove query categorization from core * Add changelog * Trigger Build --------- * Add changes to propagate queryGroupId across child requests and nodes (#14614) * add query group header propagator * apply spotless check * add new propagator in ThreadContext * spotlessApply * address comments * Bump com.microsoft.azure:msal4j from 1.15.1 to 1.16.0 in /plugins/repository-azure (#14610) * Bump com.microsoft.azure:msal4j in /plugins/repository-azure Bumps [com.microsoft.azure:msal4j](https://github.com/AzureAD/microsoft-authentication-library-for-java) from 1.15.1 to 1.16.0. - [Release notes](https://github.com/AzureAD/microsoft-authentication-library-for-java/releases) - [Changelog](https://github.com/AzureAD/microsoft-authentication-library-for-java/blob/dev/changelog.txt) - [Commits](AzureAD/microsoft-authentication-library-for-java@v1.15.1...v1.16.0) --- updated-dependencies: - dependency-name: com.microsoft.azure:msal4j dependency-type: direct:production update-type: version-update:semver-minor ... * Updating SHAs * Update changelog --------- * [Bugfix] Fix ICacheKeySerializerTests flakiness (#14564) * Fix testInvalidInput flakiness * Addressed andrross's comment * rerun security check --------- * Correct typo in method name (#14621) * Refactoring FilterPath.parse by using an iterative approach instead of recursion. (#14200) * Refactor FilterPath parse function (#12067) * Implement unit tests for FilterPathTests (#12067) * Write warn log if Filter is empty; Add comments (#12067) * Add changelog * Remove unnecessary log statement * Remove unused logger * Spotless apply * Remove incorrect changelog --------- * Removing String format in RemoteStoreMigrationAllocationDecider to optimise performance(#14612) * Clear templates before Adding; Use NamedWriteableAwareStreamInput for RemoteCustomMetadata; Correct the check for deciding upload of HashesOfConsistentSettings (#14513) * Clear templates before Adding; Use NamedWriteableAwareStreamInput for RemoteCustomMetadata * Correct the check for deciding upload of hashes of consistent settings * add changelog * add PR link changelog * Improve reroute performance by optimising List.removeAll in LocalShardsBalancer to filter remote search shard from relocation decision (#14613) * Fix assertion failure while deleting remote backed index (#14601) * Allow system index warning in OpenSearchRestTestCase.refreshAllIndices (#14635) * Allow system index warning * Add to CHANGELOG * Address code review comments --------- * Star tree codec changes (#14514) --------- * Bump com.github.spullara.mustache.java:compiler from 0.9.13 to 0.9.14 in /modules/lang-mustache (#14672) * Bump com.github.spullara.mustache.java:compiler Bumps [com.github.spullara.mustache.java:compiler](https://github.com/spullara/mustache.java) from 0.9.13 to 0.9.14. - [Commits](spullara/mustache.java@mustache.java-0.9.13...mustache.java-0.9.14) --- updated-dependencies: - dependency-name: com.github.spullara.mustache.java:compiler dependency-type: direct:production update-type: version-update:semver-patch ... * Updating SHAs * Update changelog --------- * Bump net.minidev:accessors-smart from 2.5.0 to 2.5.1 in /plugins/repository-azure (#14673) * Bump net.minidev:accessors-smart in /plugins/repository-azure Bumps [net.minidev:accessors-smart](https://github.com/netplex/json-smart-v2) from 2.5.0 to 2.5.1. - [Release notes](https://github.com/netplex/json-smart-v2/releases) - [Commits](netplex/json-smart-v2@2.5.0...2.5.1) --- updated-dependencies: - dependency-name: net.minidev:accessors-smart dependency-type: direct:production update-type: version-update:semver-patch ... * Updating SHAs * Update changelog --------- * move query group thread context propagator out of ThreadContext --------- * Add consumers to remote store based index settings (#14764) * Add matchesPluginSystemIndexPattern to SystemIndexRegistry (#14750) * Add matchesPluginSystemIndexPattern to SystemIndexRegistry * Add to CHANGELOG * Use single data structure to keep track of system indices * Address code review comments * Add test for getAllDescriptors * Update server/src/main/java/org/opensearch/indices/SystemIndexRegistry.java --------- * SPI for loading ABC templates (#14659) * SPI for loading ABC templates * Fix bulk upsert ignores the default_pipeline and final_pipeline when the auto-created index matches the index template (#12891) * Fix bulk upsert ignores the default_pipeline and final_pipeline when auto-created index matches with the index template * Modify changelog & comment * Use new approach * Fix test failure --------- * Fix flaky test due to node being used across all tests (#14787) * Star Tree Implementation [OnHeap] (#14512) --------- * Add Gao Binlong as maintainer (#14796) * Clear ehcache disk cache files during initialization (#14738) * Clear ehcache disk cache files during initialization * Adding UT to fix line coverage * Addressing comment * Adding more Uts for better line coverage * Throwing exception in case we fail to clear cache files during startup * Adding more UTs * Adding a UT for more coverage * Fixing gradle build * Update ehcache disk cache close() logic --------- * Refactor remote-routing-table service inline with remote state interfaces (#14668) --------- * Set version to 2.15 for determining metadata during migration to remote store * Fix bulk upsert ignores the default_pipeline and final_pipeline when the auto-created index matches the index template (#14793) * Fix create or update alias API doesn't throw exception for unsupported parameters (#14769) * Change RCSS info logs to debug (#14814) * [Bugfix] Fix NPE in ReplicaShardAllocator (#13993) (#14385) * [Bugfix] Fix NPE in ReplicaShardAllocator (#13993) * Add fix info to CHANGELOG.md --------- * Run performance benchmark on pull requests (#14760) * add performance benchmark workflow for pull requests * Update PERFORMANCE_BENCHMARKS.md * Update PERFORMANCE_BENCHMARKS.md * Update .github/workflows/benchmark-pull-request.yml * Update .github/workflows/benchmark-pull-request.yml * Update .github/workflows/benchmark-pull-request.yml * Update .github/workflows/benchmark-pull-request.yml --------- * fix constant_keyword field type (#14807) test * [Remote Store Migration] Reconcile remote store based index settings during STRICT mode switch (#14792) * Add prefix mode verification setting for repository verification (#14790) * Add prefix mode verification setting for repository verification * Add UTs and randomise prefix mode repository verification * Incorporate PR review feedback --------- * add length check on comment body for benchmark workflow (#14834) * Add restore-from-snapshot test procedure for snapshot run benchmark config (#14842) * Fix env variable name typo (#14843) * Use circuit breaker in InternalHistogram when adding empty buckets (#14754) * introduce circuit breaker in InternalHistogram * use circuit breaker from reduce context * add test * revert use_real_memory change in OpenSearchNode * add change log --------- * [Remote State] Create interface RemoteEntitiesManager (#14671) * Create interface RemoteEntitiesManager * Optimise TransportNodesAction to not send DiscoveryNodes for NodeStat… (#14749) * Optimize TransportNodesAction to not send DiscoveryNodes for NodeStats, NodesInfo and ClusterStats call * Enabling term version check on local state for all ClusterManager Read Transport Actions (#14273) * enabling term version check on local state for all admin read actions * Reduce logging in DEBUG for MasterService:run (#14795) * Reduce logging in DEBUG for MasteService:run by introducing short and long summary in Taskbatcher * Add SplitResponseProcessor to Search Pipelines (#14800) * Add SplitResponseProcessor for search pipelines * Register the split processor factory * Address code review comments * Avoid list copy by casting array --------- * Add integration tests for RemoteRoutingTable Service. (#14631) * Add SortResponseProcessor to Search Pipelines (#14785) * Add SortResponseProcessor for search pipelines * Add stupid and unnecessary javadocs to satisfy overly strict CI * Split casting and sorting methods for readability * Register the sort processor factory * Address code review comments * Cast individual list elements to avoid creating two lists * Add yamlRestTests * Clarify why there's unusual sorting * Use instanceof instead of isAssignableFrom --------- * Fix allowUnmappedFields, mapUnmappedFieldAsString settings to be applied when parsing query string query (#13957) * Modify to invoke QueryShardContext.fieldMapper() method to apply allowUnmappedFields and mapUnmappedFieldAsString settings * Add test cases to verify returning 400 responses if unmapped fields are included for some types of query * Add changelog --------- * Bump com.microsoft.azure:msal4j from 1.16.0 to 1.16.1 in /plugins/repository-azure (#14857) * Bump com.microsoft.azure:msal4j in /plugins/repository-azure Bumps [com.microsoft.azure:msal4j](https://github.com/AzureAD/microsoft-authentication-library-for-java) from 1.16.0 to 1.16.1. - [Release notes](https://github.com/AzureAD/microsoft-authentication-library-for-java/releases) - [Changelog](https://github.com/AzureAD/microsoft-authentication-library-for-java/blob/dev/changelog.txt) - [Commits](AzureAD/microsoft-authentication-library-for-java@v1.16.0...v1.16.1) --- updated-dependencies: - dependency-name: com.microsoft.azure:msal4j dependency-type: direct:production update-type: version-update:semver-patch ... * Updating SHAs * Update changelog --------- * Bump com.gradle.develocity from 3.17.5 to 3.17.6 (#14856) * Bump com.gradle.develocity from 3.17.5 to 3.17.6 Bumps com.gradle.develocity from 3.17.5 to 3.17.6. --- updated-dependencies: - dependency-name: com.gradle.develocity dependency-type: direct:production update-type: version-update:semver-patch ... * Update changelog --------- * Bump org.jline:jline in /test/fixtures/hdfs-fixture (#14859) Bumps [org.jline:jline](https://github.com/jline/jline3) from 3.26.2 to 3.26.3. - [Release notes](https://github.com/jline/jline3/releases) - [Changelog](https://github.com/jline/jline3/blob/master/changelog.md) - [Commits](jline/jline3@jline-parent-3.26.2...jline-parent-3.26.3) --- updated-dependencies: - dependency-name: org.jline:jline dependency-type: direct:production update-type: version-update:semver-patch ... * Use Lucene provided Persian stem (#14847) Lucene provided Persian stem apparently isn't hooked yet and this change is doing that based on what is done for Arabic stem support. * Bump actions/checkout from 2 to 4 (#14858) * Bump actions/checkout from 2 to 4 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... * Update changelog --------- * Deprecate batch_size parameter on bulk API (#14725) By default the full _bulk payload will be passed to ingest processors as a batch, with any sub batching logic to be implemented by each processor if necessary. * Add perms for remote snapshot cache eviction on scripted query (#14411) * add transport interceptor to populate queryGroupId in task headers * Add rest, transport layer changes for Hot to warm tiering - dedicated setup (#13980) * Create listener to refresh search thread resource usage (#14832) * [bug fix] fix incorrect coordinator node search resource usages * fix bug on serialization when passing task resource usage to coordinator * add more unit tests * remove query insights plugin related code * create per request listener to refresh task resource usage * Make new listener API public * Add changelog * Remove wrong files added * Address review comments * Build fix * Make singleton * Address review comments * Make sure listener runs before plugin listeners * Spotless * Minor fix --------- * Caching avg total bytes and avg free bytes inside ClusterInfo (#14851) * Use default value when index.number_of_replicas is null (#14812) * Use default value when index.number_of_replicas is null * Add integration test * Add changelog --------- * [Remote Routing Table] Implement write and read flow for shard diff file. (#14684) * Implement write and read flow to upload/download shard diff file. * Optimized ClusterStatsIndices to precomute shard stats (#14426) * Optimize Cluster Stats Indices to precomute node level stats * Fix constraint bug which allows more primary shards than average primary shards per index (#14908) * Optmising AwarenessAllocationDecider for hashmap.get call (#14761) * update comment * Fix IngestServiceTests.testBulkRequestExecutionWithFailures (#14918) The test would previously fail if the randomness led to only a single indexing request being included in the bulk payload. This change guarantees multiple indexing requests in order to ensure the batch logic kicks in. Also replace some unneeded mocks with real classes. * add queryGroupTask * remove unnecessary imports * add QueryGroupTask tests * rename WLM transport request handler * add CHANGELOG entry * fix ut * address comments * fix UT to remove the verify for final method * apply spotless --------- (cherry picked from commit eb306d2) Signed-off-by: Kaushal Kumar <[email protected]> Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Sandesh Kumar <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: Lukáš Vlček <[email protected]> Signed-off-by: kkewwei <[email protected]> Signed-off-by: Swetha Guptha <[email protected]> Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: ahmedsobeh <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: vatsal <[email protected]> Signed-off-by: Sachin Kale <[email protected]> Signed-off-by: Shourya Dutta Biswas <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: mgodwan <[email protected]> Signed-off-by: Mohit Godwani <[email protected]> Signed-off-by: Sagar Upadhyaya <[email protected]> Signed-off-by: Sandeep Kumawat <[email protected]> Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: Ashish Singh <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: Pranshu Shukla <[email protected]> Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]> Signed-off-by: Sumit Bansal <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: imyp92 <[email protected]> Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Ebrahim Byagowi <[email protected]> Signed-off-by: Liyun Xiu <[email protected]> Signed-off-by: Finn Carroll <[email protected]> Signed-off-by: Neetika Singhal <[email protected]> Signed-off-by: Jay Deng <[email protected]> Signed-off-by: Gaurav Bafna <[email protected]> Signed-off-by: Andrew Ross <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Shivansh Arora <[email protected]> Co-authored-by: Arpit-Bandejiya <[email protected]> Co-authored-by: gaobinlong <[email protected]> Co-authored-by: rishavz_sagar <[email protected]> Co-authored-by: Chenyang Ji <[email protected]> Co-authored-by: Craig Perkins <[email protected]> Co-authored-by: Sandesh Kumar <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Co-authored-by: Zelin Hao <[email protected]> Co-authored-by: Lukáš Vlček <[email protected]> Co-authored-by: kkewwei <[email protected]> Co-authored-by: SwethaGuptha <[email protected]> Co-authored-by: Sooraj Sinha <[email protected]> Co-authored-by: Ahmed Sobeh <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Siddhant Deshmukh <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: Vatsal <[email protected]> Co-authored-by: Robin Friedmann <[email protected]> Co-authored-by: Sachin Kale <[email protected]> Co-authored-by: Bharathwaj G <[email protected]> Co-authored-by: Shourya Dutta Biswas <[email protected]> Co-authored-by: Craig Perkins <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Co-authored-by: Mohit Godwani <[email protected]> Co-authored-by: Sarthak Aggarwal <[email protected]> Co-authored-by: Sagar <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]> Co-authored-by: Daniil Roman <[email protected]> Co-authored-by: Rishabh Singh <[email protected]> Co-authored-by: kkewwei <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Ashish Singh <[email protected]> Co-authored-by: bowenlan-amzn <[email protected]> Co-authored-by: Pranshu Shukla <[email protected]> Co-authored-by: rajiv-kv <[email protected]> Co-authored-by: Sumit Bansal <[email protected]> Co-authored-by: Daniel Widdis <[email protected]> Co-authored-by: shailendra0811 <[email protected]> Co-authored-by: Park, Yeongwu <[email protected]> Co-authored-by: ebraminio <[email protected]> Co-authored-by: Liyun Xiu <[email protected]> Co-authored-by: Finn <[email protected]> Co-authored-by: Neetika Singhal <[email protected]> Co-authored-by: Jay Deng <[email protected]> Co-authored-by: Gaurav Bafna <[email protected]> Co-authored-by: Andrew Ross <[email protected]>
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Aug 20, 2024
…de level (opensearch-project#14708) * add logic to add headers to Task Signed-off-by: Kaushal Kumar <[email protected]> * add logic to add queryGroupId to task headers Signed-off-by: Kaushal Kumar <[email protected]> * remove redundant code Signed-off-by: Kaushal Kumar <[email protected]> * add changelog entry Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * fix precommit Signed-off-by: Kaushal Kumar <[email protected]> * Add UTs for RemoteIndexMetadataManager (opensearch-project#14660) Signed-off-by: Shivansh Arora <[email protected]> Co-authored-by: Arpit-Bandejiya <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix match_phrase_prefix_query not working on text field with multiple values and index_prefixes (opensearch-project#10959) * Fix match_phrase_prefix_query not working on text field with multiple values and index_prefixes Signed-off-by: Gao Binlong <[email protected]> * Add more test Signed-off-by: Gao Binlong <[email protected]> * modify change log Signed-off-by: Gao Binlong <[email protected]> * Fix test failure Signed-off-by: Gao Binlong <[email protected]> * Change the indexAnalyzer used by prefix field Signed-off-by: Gao Binlong <[email protected]> * Skip old version for yaml test Signed-off-by: Gao Binlong <[email protected]> * Optimize some code Signed-off-by: Gao Binlong <[email protected]> * Fix test failure Signed-off-by: Gao Binlong <[email protected]> * Modify yaml test description Signed-off-by: Gao Binlong <[email protected]> * Remove the name parameter for setAnalyzer() Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Offline calculation of total shard per node and caching it for weight calculation inside LocalShardBalancer (opensearch-project#14675) Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * [bug fix] validate lower bound for top n size (opensearch-project#14587) Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Create SystemIndexRegistry with helper method matchesSystemIndex (opensearch-project#14415) * Create new extension point in SystemIndexPlugin for a single plugin to get registered system indices Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * WIP on system indices from IndexNameExpressionResolver Signed-off-by: Craig Perkins <[email protected]> * Add test in IndexNameExpressionResolverTests Signed-off-by: Craig Perkins <[email protected]> * Remove changes in SystemIndexPlugin Signed-off-by: Craig Perkins <[email protected]> * Add method in IndexNameExpressionResolver to get matching system indices Signed-off-by: Craig Perkins <[email protected]> * Show how resolver can be chained to get system indices Signed-off-by: Craig Perkins <[email protected]> * Fix forbiddenApis check Signed-off-by: Craig Perkins <[email protected]> * Update CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Make SystemIndices internal Signed-off-by: Craig Perkins <[email protected]> * Remove unneeded changes Signed-off-by: Craig Perkins <[email protected]> * Fix CI failures Signed-off-by: Craig Perkins <[email protected]> * Fix precommit errors Signed-off-by: Craig Perkins <[email protected]> * Use Regex instead of WildcardMatcher Signed-off-by: Craig Perkins <[email protected]> * Address code review feedback Signed-off-by: Craig Perkins <[email protected]> * Allow caller to pass index expressions Signed-off-by: Craig Perkins <[email protected]> * Create SystemIndexRegistry Signed-off-by: Craig Perkins <[email protected]> * Update CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Remove singleton limitation Signed-off-by: Craig Perkins <[email protected]> * Add javadoc Signed-off-by: Craig Perkins <[email protected]> * Add @experimentalapi annotation Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Refactor Grok validate pattern to iterative approach (opensearch-project#14206) * grok validate patterns recusrion to iterative Signed-off-by: Sandesh Kumar <[email protected]> * Add max depth in resolving a pattern to avoid OOM Signed-off-by: Sandesh Kumar <[email protected]> * change path from deque to arraylist Signed-off-by: Sandesh Kumar <[email protected]> * rename queue to stack Signed-off-by: Sandesh Kumar <[email protected]> * Change max depth to 500 Signed-off-by: Sandesh Kumar <[email protected]> * typo originPatternName fix Signed-off-by: Sandesh Kumar <[email protected]> * spotless Signed-off-by: Sandesh Kumar <[email protected]> --------- Signed-off-by: Sandesh Kumar <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump opentelemetry from 1.39.0 to 1.40.0 (opensearch-project#14674) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump jackson from 2.17.1 to 2.17.2 (opensearch-project#14687) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add release notes for release 1.3.18 (opensearch-project#14699) Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump reactor from 3.5.19 to 3.5.20 (opensearch-project#14697) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add unit tests for read flow of RemoteClusterStateService and bug fix for transient settings (opensearch-project#14476) Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Update version check for the bug fix of match_phrase_prefix_query not working on text field with multiple values and index_prefixes (opensearch-project#14703) Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Remove unnecessary cast to int from test (opensearch-project#14696) Signed-off-by: Lukáš Vlček <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * print reason why parent task was cancelled (opensearch-project#14604) Signed-off-by: kkewwei <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Use set of shard routing for shard in unassigned shard batch check. (opensearch-project#14533) Signed-off-by: Swetha Guptha <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add versioning for UploadedIndexMetadata (opensearch-project#14677) * Add versioning for UploadedIndexMetadata * Handle componentPrefix for backward compatibility Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix: update help output for _cat (opensearch-project#14722) * fixed help output for _cat Signed-off-by: ahmedsobeh <[email protected]> * updated changelog Signed-off-by: ahmedsobeh <[email protected]> * updated changelog Signed-off-by: ahmedsobeh <[email protected]> --------- Signed-off-by: ahmedsobeh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix hdfs-fixture kerb-admin & hadoop-minicluster dependencies are not being updated / false positive reports on CVEs (opensearch-project#14729) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Update to Gradle 8.9 (opensearch-project#14574) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix hdfs-fixture hadoop-minicluster dependencies are not being updated / false positive reports on CVEs (opensearch-project#14732) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add `strict_allow_templates` dynamic mapping option (opensearch-project#14555) * The dynamic mapping parameter supports strict_allow_templates Signed-off-by: Gao Binlong <[email protected]> * Modify change log Signed-off-by: Gao Binlong <[email protected]> * Modify skip version in yml test file Signed-off-by: Gao Binlong <[email protected]> * Refactor some code Signed-off-by: Gao Binlong <[email protected]> * Keep the old methods Signed-off-by: Gao Binlong <[email protected]> * change public to private Signed-off-by: Gao Binlong <[email protected]> * Optimize some code Signed-off-by: Gao Binlong <[email protected]> * Do not override toString method for Dynamic Signed-off-by: Gao Binlong <[email protected]> * Optimize some code and modify the changelog Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump net.minidev:json-smart from 2.5.0 to 2.5.1 in /plugins/repository-azure (opensearch-project#14748) * Bump net.minidev:json-smart in /plugins/repository-azure Bumps [net.minidev:json-smart](https://github.com/netplex/json-smart-v2) from 2.5.0 to 2.5.1. - [Release notes](https://github.com/netplex/json-smart-v2/releases) - [Commits](netplex/json-smart-v2@2.5.0...2.5.1) --- updated-dependencies: - dependency-name: net.minidev:json-smart dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * remove query insights plugin from core (opensearch-project#14743) Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add `strict_allow_templates` dynamic mapping option (opensearch-project#14555) (opensearch-project#14737) (opensearch-project#14742) * The dynamic mapping parameter supports strict_allow_templates * Modify change log * Modify skip version in yml test file * Refactor some code * Keep the old methods * change public to private * Optimize some code * Do not override toString method for Dynamic * Optimize some code and modify the changelog --------- (cherry picked from commit 6b8b3ef) Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * Fix create or update alias API doesn't throw exception for unsupported parameters (opensearch-project#14719) * Fix create or update alias API doesn't throw exception for unsupported parameters Signed-off-by: Gao Binlong <[email protected]> * Update version check in yml test Signed-off-by: Gao Binlong <[email protected]> * modify change log Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Remove query categorization from core (opensearch-project#14759) * Remove query categorization from core Signed-off-by: Siddhant Deshmukh <[email protected]> * Add changelog Signed-off-by: Siddhant Deshmukh <[email protected]> * Trigger Build Signed-off-by: Siddhant Deshmukh <[email protected]> --------- Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add changes to propagate queryGroupId across child requests and nodes (opensearch-project#14614) * add query group header propagator Signed-off-by: Kaushal Kumar <[email protected]> * apply spotless check Signed-off-by: Kaushal Kumar <[email protected]> * add new propagator in ThreadContext Signed-off-by: Kaushal Kumar <[email protected]> * spotlessApply Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * Bump com.microsoft.azure:msal4j from 1.15.1 to 1.16.0 in /plugins/repository-azure (opensearch-project#14610) * Bump com.microsoft.azure:msal4j in /plugins/repository-azure Bumps [com.microsoft.azure:msal4j](https://github.com/AzureAD/microsoft-authentication-library-for-java) from 1.15.1 to 1.16.0. - [Release notes](https://github.com/AzureAD/microsoft-authentication-library-for-java/releases) - [Changelog](https://github.com/AzureAD/microsoft-authentication-library-for-java/blob/dev/changelog.txt) - [Commits](AzureAD/microsoft-authentication-library-for-java@v1.15.1...v1.16.0) --- updated-dependencies: - dependency-name: com.microsoft.azure:msal4j dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * [Bugfix] Fix ICacheKeySerializerTests flakiness (opensearch-project#14564) * Fix testInvalidInput flakiness Signed-off-by: Peter Alfonsi <[email protected]> * Addressed andrross's comment Signed-off-by: Peter Alfonsi <[email protected]> * rerun security check Signed-off-by: Peter Alfonsi <[email protected]> --------- Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Correct typo in method name (opensearch-project#14621) Signed-off-by: vatsal <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Refactoring FilterPath.parse by using an iterative approach instead of recursion. (opensearch-project#14200) * Refactor FilterPath parse function (opensearch-project#12067) Signed-off-by: Robin Friedmann <[email protected]> * Implement unit tests for FilterPathTests (opensearch-project#12067) Signed-off-by: Robin Friedmann <[email protected]> * Write warn log if Filter is empty; Add comments (opensearch-project#12067) Signed-off-by: Robin Friedmann <[email protected]> * Add changelog Signed-off-by: Siddhant Deshmukh <[email protected]> * Remove unnecessary log statement Signed-off-by: Siddhant Deshmukh <[email protected]> * Remove unused logger Signed-off-by: Siddhant Deshmukh <[email protected]> * Spotless apply Signed-off-by: Siddhant Deshmukh <[email protected]> * Remove incorrect changelog Signed-off-by: Siddhant Deshmukh <[email protected]> --------- Signed-off-by: Siddhant Deshmukh <[email protected]> Co-authored-by: Robin Friedmann <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Removing String format in RemoteStoreMigrationAllocationDecider to optimise performance(opensearch-project#14612) Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Clear templates before Adding; Use NamedWriteableAwareStreamInput for RemoteCustomMetadata; Correct the check for deciding upload of HashesOfConsistentSettings (opensearch-project#14513) * Clear templates before Adding; Use NamedWriteableAwareStreamInput for RemoteCustomMetadata * Correct the check for deciding upload of hashes of consistent settings Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * add changelog Signed-off-by: Kaushal Kumar <[email protected]> * add PR link changelog Signed-off-by: Kaushal Kumar <[email protected]> * Improve reroute performance by optimising List.removeAll in LocalShardsBalancer to filter remote search shard from relocation decision (opensearch-project#14613) Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix assertion failure while deleting remote backed index (opensearch-project#14601) Signed-off-by: Sachin Kale <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Allow system index warning in OpenSearchRestTestCase.refreshAllIndices (opensearch-project#14635) * Allow system index warning Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Address code review comments Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Star tree codec changes (opensearch-project#14514) --------- Signed-off-by: Bharathwaj G <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump com.github.spullara.mustache.java:compiler from 0.9.13 to 0.9.14 in /modules/lang-mustache (opensearch-project#14672) * Bump com.github.spullara.mustache.java:compiler Bumps [com.github.spullara.mustache.java:compiler](https://github.com/spullara/mustache.java) from 0.9.13 to 0.9.14. - [Commits](spullara/mustache.java@mustache.java-0.9.13...mustache.java-0.9.14) --- updated-dependencies: - dependency-name: com.github.spullara.mustache.java:compiler dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * Bump net.minidev:accessors-smart from 2.5.0 to 2.5.1 in /plugins/repository-azure (opensearch-project#14673) * Bump net.minidev:accessors-smart in /plugins/repository-azure Bumps [net.minidev:accessors-smart](https://github.com/netplex/json-smart-v2) from 2.5.0 to 2.5.1. - [Release notes](https://github.com/netplex/json-smart-v2/releases) - [Commits](netplex/json-smart-v2@2.5.0...2.5.1) --- updated-dependencies: - dependency-name: net.minidev:accessors-smart dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * move query group thread context propagator out of ThreadContext Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: vatsal <[email protected]> Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: Sachin Kale <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: Vatsal <[email protected]> Co-authored-by: Siddhant Deshmukh <[email protected]> Co-authored-by: Robin Friedmann <[email protected]> Co-authored-by: rishavz_sagar <[email protected]> Co-authored-by: Sooraj Sinha <[email protected]> Co-authored-by: Sachin Kale <[email protected]> Co-authored-by: Craig Perkins <[email protected]> Co-authored-by: Bharathwaj G <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add consumers to remote store based index settings (opensearch-project#14764) Signed-off-by: Shourya Dutta Biswas <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add matchesPluginSystemIndexPattern to SystemIndexRegistry (opensearch-project#14750) * Add matchesPluginSystemIndexPattern to SystemIndexRegistry Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Use single data structure to keep track of system indices Signed-off-by: Craig Perkins <[email protected]> * Address code review comments Signed-off-by: Craig Perkins <[email protected]> * Add test for getAllDescriptors Signed-off-by: Craig Perkins <[email protected]> * Update server/src/main/java/org/opensearch/indices/SystemIndexRegistry.java Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * SPI for loading ABC templates (opensearch-project#14659) * SPI for loading ABC templates Signed-off-by: mgodwan <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix bulk upsert ignores the default_pipeline and final_pipeline when the auto-created index matches the index template (opensearch-project#12891) * Fix bulk upsert ignores the default_pipeline and final_pipeline when auto-created index matches with the index template Signed-off-by: Gao Binlong <[email protected]> * Modify changelog & comment Signed-off-by: Gao Binlong <[email protected]> * Use new approach Signed-off-by: Gao Binlong <[email protected]> * Fix test failure Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix flaky test due to node being used across all tests (opensearch-project#14787) Signed-off-by: Mohit Godwani <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Star Tree Implementation [OnHeap] (opensearch-project#14512) --------- Signed-off-by: Sarthak Aggarwal <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add Gao Binlong as maintainer (opensearch-project#14796) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Clear ehcache disk cache files during initialization (opensearch-project#14738) * Clear ehcache disk cache files during initialization Signed-off-by: Sagar Upadhyaya <[email protected]> * Adding UT to fix line coverage Signed-off-by: Sagar Upadhyaya <[email protected]> * Addressing comment Signed-off-by: Sagar Upadhyaya <[email protected]> * Adding more Uts for better line coverage Signed-off-by: Sagar Upadhyaya <[email protected]> * Throwing exception in case we fail to clear cache files during startup Signed-off-by: Sagar Upadhyaya <[email protected]> * Adding more UTs Signed-off-by: Sagar Upadhyaya <[email protected]> * Adding a UT for more coverage Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing gradle build Signed-off-by: Sagar Upadhyaya <[email protected]> * Update ehcache disk cache close() logic Signed-off-by: Sagar Upadhyaya <[email protected]> --------- Signed-off-by: Sagar Upadhyaya <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Refactor remote-routing-table service inline with remote state interfaces (opensearch-project#14668) --------- Signed-off-by: Arpit Bandejiya <[email protected]> Signed-off-by: Arpit-Bandejiya <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Set version to 2.15 for determining metadata during migration to remote store Signed-off-by: Sandeep Kumawat <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix bulk upsert ignores the default_pipeline and final_pipeline when the auto-created index matches the index template (opensearch-project#14793) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix create or update alias API doesn't throw exception for unsupported parameters (opensearch-project#14769) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Change RCSS info logs to debug (opensearch-project#14814) Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * [Bugfix] Fix NPE in ReplicaShardAllocator (opensearch-project#13993) (opensearch-project#14385) * [Bugfix] Fix NPE in ReplicaShardAllocator (opensearch-project#13993) Signed-off-by: Daniil Roman <[email protected]> * Add fix info to CHANGELOG.md Signed-off-by: Daniil Roman <[email protected]> --------- Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Run performance benchmark on pull requests (opensearch-project#14760) * add performance benchmark workflow for pull requests Signed-off-by: Rishabh Singh <[email protected]> * Update PERFORMANCE_BENCHMARKS.md Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> * Update PERFORMANCE_BENCHMARKS.md Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> * Update .github/workflows/benchmark-pull-request.yml Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> * Update .github/workflows/benchmark-pull-request.yml Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> * Update .github/workflows/benchmark-pull-request.yml Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> * Update .github/workflows/benchmark-pull-request.yml Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> --------- Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * fix constant_keyword field type (opensearch-project#14807) Signed-off-by: kkewwei <[email protected]> test Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * [Remote Store Migration] Reconcile remote store based index settings during STRICT mode switch (opensearch-project#14792) Signed-off-by: Shourya Dutta Biswas <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add prefix mode verification setting for repository verification (opensearch-project#14790) * Add prefix mode verification setting for repository verification Signed-off-by: Ashish Singh <[email protected]> * Add UTs and randomise prefix mode repository verification Signed-off-by: Ashish Singh <[email protected]> * Incorporate PR review feedback Signed-off-by: Ashish Singh <[email protected]> --------- Signed-off-by: Ashish Singh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * add length check on comment body for benchmark workflow (opensearch-project#14834) Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add restore-from-snapshot test procedure for snapshot run benchmark config (opensearch-project#14842) Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix env variable name typo (opensearch-project#14843) Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Use circuit breaker in InternalHistogram when adding empty buckets (opensearch-project#14754) * introduce circuit breaker in InternalHistogram Signed-off-by: bowenlan-amzn <[email protected]> * use circuit breaker from reduce context Signed-off-by: bowenlan-amzn <[email protected]> * add test Signed-off-by: bowenlan-amzn <[email protected]> * revert use_real_memory change in OpenSearchNode Signed-off-by: bowenlan-amzn <[email protected]> * add change log Signed-off-by: bowenlan-amzn <[email protected]> --------- Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * [Remote State] Create interface RemoteEntitiesManager (opensearch-project#14671) * Create interface RemoteEntitiesManager Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Optimise TransportNodesAction to not send DiscoveryNodes for NodeStat… (opensearch-project#14749) * Optimize TransportNodesAction to not send DiscoveryNodes for NodeStats, NodesInfo and ClusterStats call Signed-off-by: Pranshu Shukla <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Enabling term version check on local state for all ClusterManager Read Transport Actions (opensearch-project#14273) * enabling term version check on local state for all admin read actions Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Reduce logging in DEBUG for MasterService:run (opensearch-project#14795) * Reduce logging in DEBUG for MasteService:run by introducing short and long summary in Taskbatcher Signed-off-by: Sumit Bansal <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add SplitResponseProcessor to Search Pipelines (opensearch-project#14800) * Add SplitResponseProcessor for search pipelines Signed-off-by: Daniel Widdis <[email protected]> * Register the split processor factory Signed-off-by: Daniel Widdis <[email protected]> * Address code review comments Signed-off-by: Daniel Widdis <[email protected]> * Avoid list copy by casting array Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add integration tests for RemoteRoutingTable Service. (opensearch-project#14631) Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add SortResponseProcessor to Search Pipelines (opensearch-project#14785) * Add SortResponseProcessor for search pipelines Signed-off-by: Daniel Widdis <[email protected]> * Add stupid and unnecessary javadocs to satisfy overly strict CI Signed-off-by: Daniel Widdis <[email protected]> * Split casting and sorting methods for readability Signed-off-by: Daniel Widdis <[email protected]> * Register the sort processor factory Signed-off-by: Daniel Widdis <[email protected]> * Address code review comments Signed-off-by: Daniel Widdis <[email protected]> * Cast individual list elements to avoid creating two lists Signed-off-by: Daniel Widdis <[email protected]> * Add yamlRestTests Signed-off-by: Daniel Widdis <[email protected]> * Clarify why there's unusual sorting Signed-off-by: Daniel Widdis <[email protected]> * Use instanceof instead of isAssignableFrom Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix allowUnmappedFields, mapUnmappedFieldAsString settings to be applied when parsing query string query (opensearch-project#13957) * Modify to invoke QueryShardContext.fieldMapper() method to apply allowUnmappedFields and mapUnmappedFieldAsString settings Signed-off-by: imyp92 <[email protected]> * Add test cases to verify returning 400 responses if unmapped fields are included for some types of query Signed-off-by: imyp92 <[email protected]> * Add changelog Signed-off-by: imyp92 <[email protected]> --------- Signed-off-by: imyp92 <[email protected]> Signed-off-by: gaobinlong <[email protected]> Co-authored-by: gaobinlong <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump com.microsoft.azure:msal4j from 1.16.0 to 1.16.1 in /plugins/repository-azure (opensearch-project#14857) * Bump com.microsoft.azure:msal4j in /plugins/repository-azure Bumps [com.microsoft.azure:msal4j](https://github.com/AzureAD/microsoft-authentication-library-for-java) from 1.16.0 to 1.16.1. - [Release notes](https://github.com/AzureAD/microsoft-authentication-library-for-java/releases) - [Changelog](https://github.com/AzureAD/microsoft-authentication-library-for-java/blob/dev/changelog.txt) - [Commits](AzureAD/microsoft-authentication-library-for-java@v1.16.0...v1.16.1) --- updated-dependencies: - dependency-name: com.microsoft.azure:msal4j dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * Bump com.gradle.develocity from 3.17.5 to 3.17.6 (opensearch-project#14856) * Bump com.gradle.develocity from 3.17.5 to 3.17.6 Bumps com.gradle.develocity from 3.17.5 to 3.17.6. --- updated-dependencies: - dependency-name: com.gradle.develocity dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * Bump org.jline:jline in /test/fixtures/hdfs-fixture (opensearch-project#14859) Bumps [org.jline:jline](https://github.com/jline/jline3) from 3.26.2 to 3.26.3. - [Release notes](https://github.com/jline/jline3/releases) - [Changelog](https://github.com/jline/jline3/blob/master/changelog.md) - [Commits](jline/jline3@jline-parent-3.26.2...jline-parent-3.26.3) --- updated-dependencies: - dependency-name: org.jline:jline dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * Use Lucene provided Persian stem (opensearch-project#14847) Lucene provided Persian stem apparently isn't hooked yet and this change is doing that based on what is done for Arabic stem support. Signed-off-by: Ebrahim Byagowi <[email protected]> Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump actions/checkout from 2 to 4 (opensearch-project#14858) * Bump actions/checkout from 2 to 4 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * Deprecate batch_size parameter on bulk API (opensearch-project#14725) By default the full _bulk payload will be passed to ingest processors as a batch, with any sub batching logic to be implemented by each processor if necessary. Signed-off-by: Liyun Xiu <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add perms for remote snapshot cache eviction on scripted query (opensearch-project#14411) Signed-off-by: Finn Carroll <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * add transport interceptor to populate queryGroupId in task headers Signed-off-by: Kaushal Kumar <[email protected]> * Add rest, transport layer changes for Hot to warm tiering - dedicated setup (opensearch-project#13980) Signed-off-by: Neetika Singhal <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Create listener to refresh search thread resource usage (opensearch-project#14832) * [bug fix] fix incorrect coordinator node search resource usages Signed-off-by: Chenyang Ji <[email protected]> * fix bug on serialization when passing task resource usage to coordinator Signed-off-by: Chenyang Ji <[email protected]> * add more unit tests Signed-off-by: Chenyang Ji <[email protected]> * remove query insights plugin related code Signed-off-by: Chenyang Ji <[email protected]> * create per request listener to refresh task resource usage Signed-off-by: Chenyang Ji <[email protected]> * Make new listener API public Signed-off-by: Siddhant Deshmukh <[email protected]> * Add changelog Signed-off-by: Siddhant Deshmukh <[email protected]> * Remove wrong files added Signed-off-by: Siddhant Deshmukh <[email protected]> * Address review comments Signed-off-by: Siddhant Deshmukh <[email protected]> * Build fix Signed-off-by: Siddhant Deshmukh <[email protected]> * Make singleton Signed-off-by: Siddhant Deshmukh <[email protected]> * Address review comments Signed-off-by: Siddhant Deshmukh <[email protected]> * Make sure listener runs before plugin listeners Signed-off-by: Siddhant Deshmukh <[email protected]> * Spotless Signed-off-by: Siddhant Deshmukh <[email protected]> * Minor fix Signed-off-by: Siddhant Deshmukh <[email protected]> --------- Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: Jay Deng <[email protected]> Co-authored-by: Chenyang Ji <[email protected]> Co-authored-by: Jay Deng <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Caching avg total bytes and avg free bytes inside ClusterInfo (opensearch-project#14851) Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Use default value when index.number_of_replicas is null (opensearch-project#14812) * Use default value when index.number_of_replicas is null Signed-off-by: Liyun Xiu <[email protected]> * Add integration test Signed-off-by: Liyun Xiu <[email protected]> * Add changelog Signed-off-by: Liyun Xiu <[email protected]> --------- Signed-off-by: Liyun Xiu <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * [Remote Routing Table] Implement write and read flow for shard diff file. (opensearch-project#14684) * Implement write and read flow to upload/download shard diff file. Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Optimized ClusterStatsIndices to precomute shard stats (opensearch-project#14426) * Optimize Cluster Stats Indices to precomute node level stats Signed-off-by: Pranshu Shukla <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix constraint bug which allows more primary shards than average primary shards per index (opensearch-project#14908) Signed-off-by: Gaurav Bafna <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Optmising AwarenessAllocationDecider for hashmap.get call (opensearch-project#14761) Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * update comment Signed-off-by: Kaushal Kumar <[email protected]> * Fix IngestServiceTests.testBulkRequestExecutionWithFailures (opensearch-project#14918) The test would previously fail if the randomness led to only a single indexing request being included in the bulk payload. This change guarantees multiple indexing requests in order to ensure the batch logic kicks in. Also replace some unneeded mocks with real classes. Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * add queryGroupTask Signed-off-by: Kaushal Kumar <[email protected]> * remove unnecessary imports Signed-off-by: Kaushal Kumar <[email protected]> * add QueryGroupTask tests Signed-off-by: Kaushal Kumar <[email protected]> * rename WLM transport request handler Signed-off-by: Kaushal Kumar <[email protected]> * add CHANGELOG entry Signed-off-by: Kaushal Kumar <[email protected]> * fix ut Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * fix UT to remove the verify for final method Signed-off-by: Kaushal Kumar <[email protected]> * apply spotless Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]> Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Sandesh Kumar <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: Lukáš Vlček <[email protected]> Signed-off-by: kkewwei <[email protected]> Signed-off-by: Swetha Guptha <[email protected]> Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: ahmedsobeh <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: vatsal <[email protected]> Signed-off-by: Sachin Kale <[email protected]> Signed-off-by: Shourya Dutta Biswas <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: mgodwan <[email protected]> Signed-off-by: Mohit Godwani <[email protected]> Signed-off-by: Sagar Upadhyaya <[email protected]> Signed-off-by: Sandeep Kumawat <[email protected]> Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: Ashish Singh <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: Pranshu Shukla <[email protected]> Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]> Signed-off-by: Sumit Bansal <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: imyp92 <[email protected]> Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Ebrahim Byagowi <[email protected]> Signed-off-by: Liyun Xiu <[email protected]> Signed-off-by: Finn Carroll <[email protected]> Signed-off-by: Neetika Singhal <[email protected]> Signed-off-by: Jay Deng <[email protected]> Signed-off-by: Gaurav Bafna <[email protected]> Signed-off-by: Andrew Ross <[email protected]> Co-authored-by: Shivansh Arora <[email protected]> Co-authored-by: Arpit-Bandejiya <[email protected]> Co-authored-by: gaobinlong <[email protected]> Co-authored-by: rishavz_sagar <[email protected]> Co-authored-by: Chenyang Ji <[email protected]> Co-authored-by: Craig Perkins <[email protected]> Co-authored-by: Sandesh Kumar <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Co-authored-by: Zelin Hao <[email protected]> Co-authored-by: Lukáš Vlček <[email protected]> Co-authored-by: kkewwei <[email protected]> Co-authored-by: SwethaGuptha <[email protected]> Co-authored-by: Sooraj Sinha <[email protected]> Co-authored-by: Ahmed Sobeh <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Siddhant Deshmukh <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: Vatsal <[email protected]> Co-authored-by: Robin Friedmann <[email protected]> Co-authored-by: Sachin Kale <[email protected]> Co-authored-by: Bharathwaj G <[email protected]> Co-authored-by: Shourya Dutta Biswas <[email protected]> Co-authored-by: Craig Perkins <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Co-authored-by: Mohit Godwani <[email protected]> Co-authored-by: Sarthak Aggarwal <[email protected]> Co-authored-by: Sagar <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]> Co-authored-by: Daniil Roman <[email protected]> Co-authored-by: Rishabh Singh <[email protected]> Co-authored-by: kkewwei <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Ashish Singh <[email protected]> Co-authored-by: bowenlan-amzn <[email protected]> Co-authored-by: Pranshu Shukla <[email protected]> Co-authored-by: rajiv-kv <[email protected]> Co-authored-by: Sumit Bansal <[email protected]> Co-authored-by: Daniel Widdis <[email protected]> Co-authored-by: shailendra0811 <[email protected]> Co-authored-by: Park, Yeongwu <[email protected]> Co-authored-by: ebraminio <[email protected]> Co-authored-by: Liyun Xiu <[email protected]> Co-authored-by: Finn <[email protected]> Co-authored-by: Neetika Singhal <[email protected]> Co-authored-by: Jay Deng <[email protected]> Co-authored-by: Gaurav Bafna <[email protected]> Co-authored-by: Andrew Ross <[email protected]>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…pensearch-project#14385) * [Bugfix] Fix NPE in ReplicaShardAllocator (opensearch-project#13993) Signed-off-by: Daniil Roman <[email protected]> * Add fix info to CHANGELOG.md Signed-off-by: Daniil Roman <[email protected]> --------- Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Daniil Roman <[email protected]>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…de level (opensearch-project#14708) * add logic to add headers to Task Signed-off-by: Kaushal Kumar <[email protected]> * add logic to add queryGroupId to task headers Signed-off-by: Kaushal Kumar <[email protected]> * remove redundant code Signed-off-by: Kaushal Kumar <[email protected]> * add changelog entry Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * fix precommit Signed-off-by: Kaushal Kumar <[email protected]> * Add UTs for RemoteIndexMetadataManager (opensearch-project#14660) Signed-off-by: Shivansh Arora <[email protected]> Co-authored-by: Arpit-Bandejiya <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix match_phrase_prefix_query not working on text field with multiple values and index_prefixes (opensearch-project#10959) * Fix match_phrase_prefix_query not working on text field with multiple values and index_prefixes Signed-off-by: Gao Binlong <[email protected]> * Add more test Signed-off-by: Gao Binlong <[email protected]> * modify change log Signed-off-by: Gao Binlong <[email protected]> * Fix test failure Signed-off-by: Gao Binlong <[email protected]> * Change the indexAnalyzer used by prefix field Signed-off-by: Gao Binlong <[email protected]> * Skip old version for yaml test Signed-off-by: Gao Binlong <[email protected]> * Optimize some code Signed-off-by: Gao Binlong <[email protected]> * Fix test failure Signed-off-by: Gao Binlong <[email protected]> * Modify yaml test description Signed-off-by: Gao Binlong <[email protected]> * Remove the name parameter for setAnalyzer() Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Offline calculation of total shard per node and caching it for weight calculation inside LocalShardBalancer (opensearch-project#14675) Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * [bug fix] validate lower bound for top n size (opensearch-project#14587) Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Create SystemIndexRegistry with helper method matchesSystemIndex (opensearch-project#14415) * Create new extension point in SystemIndexPlugin for a single plugin to get registered system indices Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * WIP on system indices from IndexNameExpressionResolver Signed-off-by: Craig Perkins <[email protected]> * Add test in IndexNameExpressionResolverTests Signed-off-by: Craig Perkins <[email protected]> * Remove changes in SystemIndexPlugin Signed-off-by: Craig Perkins <[email protected]> * Add method in IndexNameExpressionResolver to get matching system indices Signed-off-by: Craig Perkins <[email protected]> * Show how resolver can be chained to get system indices Signed-off-by: Craig Perkins <[email protected]> * Fix forbiddenApis check Signed-off-by: Craig Perkins <[email protected]> * Update CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Make SystemIndices internal Signed-off-by: Craig Perkins <[email protected]> * Remove unneeded changes Signed-off-by: Craig Perkins <[email protected]> * Fix CI failures Signed-off-by: Craig Perkins <[email protected]> * Fix precommit errors Signed-off-by: Craig Perkins <[email protected]> * Use Regex instead of WildcardMatcher Signed-off-by: Craig Perkins <[email protected]> * Address code review feedback Signed-off-by: Craig Perkins <[email protected]> * Allow caller to pass index expressions Signed-off-by: Craig Perkins <[email protected]> * Create SystemIndexRegistry Signed-off-by: Craig Perkins <[email protected]> * Update CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Remove singleton limitation Signed-off-by: Craig Perkins <[email protected]> * Add javadoc Signed-off-by: Craig Perkins <[email protected]> * Add @experimentalapi annotation Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Refactor Grok validate pattern to iterative approach (opensearch-project#14206) * grok validate patterns recusrion to iterative Signed-off-by: Sandesh Kumar <[email protected]> * Add max depth in resolving a pattern to avoid OOM Signed-off-by: Sandesh Kumar <[email protected]> * change path from deque to arraylist Signed-off-by: Sandesh Kumar <[email protected]> * rename queue to stack Signed-off-by: Sandesh Kumar <[email protected]> * Change max depth to 500 Signed-off-by: Sandesh Kumar <[email protected]> * typo originPatternName fix Signed-off-by: Sandesh Kumar <[email protected]> * spotless Signed-off-by: Sandesh Kumar <[email protected]> --------- Signed-off-by: Sandesh Kumar <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump opentelemetry from 1.39.0 to 1.40.0 (opensearch-project#14674) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump jackson from 2.17.1 to 2.17.2 (opensearch-project#14687) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add release notes for release 1.3.18 (opensearch-project#14699) Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump reactor from 3.5.19 to 3.5.20 (opensearch-project#14697) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add unit tests for read flow of RemoteClusterStateService and bug fix for transient settings (opensearch-project#14476) Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Update version check for the bug fix of match_phrase_prefix_query not working on text field with multiple values and index_prefixes (opensearch-project#14703) Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Remove unnecessary cast to int from test (opensearch-project#14696) Signed-off-by: Lukáš Vlček <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * print reason why parent task was cancelled (opensearch-project#14604) Signed-off-by: kkewwei <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Use set of shard routing for shard in unassigned shard batch check. (opensearch-project#14533) Signed-off-by: Swetha Guptha <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add versioning for UploadedIndexMetadata (opensearch-project#14677) * Add versioning for UploadedIndexMetadata * Handle componentPrefix for backward compatibility Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix: update help output for _cat (opensearch-project#14722) * fixed help output for _cat Signed-off-by: ahmedsobeh <[email protected]> * updated changelog Signed-off-by: ahmedsobeh <[email protected]> * updated changelog Signed-off-by: ahmedsobeh <[email protected]> --------- Signed-off-by: ahmedsobeh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix hdfs-fixture kerb-admin & hadoop-minicluster dependencies are not being updated / false positive reports on CVEs (opensearch-project#14729) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Update to Gradle 8.9 (opensearch-project#14574) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix hdfs-fixture hadoop-minicluster dependencies are not being updated / false positive reports on CVEs (opensearch-project#14732) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add `strict_allow_templates` dynamic mapping option (opensearch-project#14555) * The dynamic mapping parameter supports strict_allow_templates Signed-off-by: Gao Binlong <[email protected]> * Modify change log Signed-off-by: Gao Binlong <[email protected]> * Modify skip version in yml test file Signed-off-by: Gao Binlong <[email protected]> * Refactor some code Signed-off-by: Gao Binlong <[email protected]> * Keep the old methods Signed-off-by: Gao Binlong <[email protected]> * change public to private Signed-off-by: Gao Binlong <[email protected]> * Optimize some code Signed-off-by: Gao Binlong <[email protected]> * Do not override toString method for Dynamic Signed-off-by: Gao Binlong <[email protected]> * Optimize some code and modify the changelog Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump net.minidev:json-smart from 2.5.0 to 2.5.1 in /plugins/repository-azure (opensearch-project#14748) * Bump net.minidev:json-smart in /plugins/repository-azure Bumps [net.minidev:json-smart](https://github.com/netplex/json-smart-v2) from 2.5.0 to 2.5.1. - [Release notes](https://github.com/netplex/json-smart-v2/releases) - [Commits](netplex/json-smart-v2@2.5.0...2.5.1) --- updated-dependencies: - dependency-name: net.minidev:json-smart dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * remove query insights plugin from core (opensearch-project#14743) Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add `strict_allow_templates` dynamic mapping option (opensearch-project#14555) (opensearch-project#14737) (opensearch-project#14742) * The dynamic mapping parameter supports strict_allow_templates * Modify change log * Modify skip version in yml test file * Refactor some code * Keep the old methods * change public to private * Optimize some code * Do not override toString method for Dynamic * Optimize some code and modify the changelog --------- (cherry picked from commit 6b8b3ef) Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * Fix create or update alias API doesn't throw exception for unsupported parameters (opensearch-project#14719) * Fix create or update alias API doesn't throw exception for unsupported parameters Signed-off-by: Gao Binlong <[email protected]> * Update version check in yml test Signed-off-by: Gao Binlong <[email protected]> * modify change log Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Remove query categorization from core (opensearch-project#14759) * Remove query categorization from core Signed-off-by: Siddhant Deshmukh <[email protected]> * Add changelog Signed-off-by: Siddhant Deshmukh <[email protected]> * Trigger Build Signed-off-by: Siddhant Deshmukh <[email protected]> --------- Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add changes to propagate queryGroupId across child requests and nodes (opensearch-project#14614) * add query group header propagator Signed-off-by: Kaushal Kumar <[email protected]> * apply spotless check Signed-off-by: Kaushal Kumar <[email protected]> * add new propagator in ThreadContext Signed-off-by: Kaushal Kumar <[email protected]> * spotlessApply Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * Bump com.microsoft.azure:msal4j from 1.15.1 to 1.16.0 in /plugins/repository-azure (opensearch-project#14610) * Bump com.microsoft.azure:msal4j in /plugins/repository-azure Bumps [com.microsoft.azure:msal4j](https://github.com/AzureAD/microsoft-authentication-library-for-java) from 1.15.1 to 1.16.0. - [Release notes](https://github.com/AzureAD/microsoft-authentication-library-for-java/releases) - [Changelog](https://github.com/AzureAD/microsoft-authentication-library-for-java/blob/dev/changelog.txt) - [Commits](AzureAD/microsoft-authentication-library-for-java@v1.15.1...v1.16.0) --- updated-dependencies: - dependency-name: com.microsoft.azure:msal4j dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * [Bugfix] Fix ICacheKeySerializerTests flakiness (opensearch-project#14564) * Fix testInvalidInput flakiness Signed-off-by: Peter Alfonsi <[email protected]> * Addressed andrross's comment Signed-off-by: Peter Alfonsi <[email protected]> * rerun security check Signed-off-by: Peter Alfonsi <[email protected]> --------- Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Correct typo in method name (opensearch-project#14621) Signed-off-by: vatsal <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Refactoring FilterPath.parse by using an iterative approach instead of recursion. (opensearch-project#14200) * Refactor FilterPath parse function (opensearch-project#12067) Signed-off-by: Robin Friedmann <[email protected]> * Implement unit tests for FilterPathTests (opensearch-project#12067) Signed-off-by: Robin Friedmann <[email protected]> * Write warn log if Filter is empty; Add comments (opensearch-project#12067) Signed-off-by: Robin Friedmann <[email protected]> * Add changelog Signed-off-by: Siddhant Deshmukh <[email protected]> * Remove unnecessary log statement Signed-off-by: Siddhant Deshmukh <[email protected]> * Remove unused logger Signed-off-by: Siddhant Deshmukh <[email protected]> * Spotless apply Signed-off-by: Siddhant Deshmukh <[email protected]> * Remove incorrect changelog Signed-off-by: Siddhant Deshmukh <[email protected]> --------- Signed-off-by: Siddhant Deshmukh <[email protected]> Co-authored-by: Robin Friedmann <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Removing String format in RemoteStoreMigrationAllocationDecider to optimise performance(opensearch-project#14612) Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Clear templates before Adding; Use NamedWriteableAwareStreamInput for RemoteCustomMetadata; Correct the check for deciding upload of HashesOfConsistentSettings (opensearch-project#14513) * Clear templates before Adding; Use NamedWriteableAwareStreamInput for RemoteCustomMetadata * Correct the check for deciding upload of hashes of consistent settings Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * add changelog Signed-off-by: Kaushal Kumar <[email protected]> * add PR link changelog Signed-off-by: Kaushal Kumar <[email protected]> * Improve reroute performance by optimising List.removeAll in LocalShardsBalancer to filter remote search shard from relocation decision (opensearch-project#14613) Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix assertion failure while deleting remote backed index (opensearch-project#14601) Signed-off-by: Sachin Kale <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Allow system index warning in OpenSearchRestTestCase.refreshAllIndices (opensearch-project#14635) * Allow system index warning Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Address code review comments Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Star tree codec changes (opensearch-project#14514) --------- Signed-off-by: Bharathwaj G <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump com.github.spullara.mustache.java:compiler from 0.9.13 to 0.9.14 in /modules/lang-mustache (opensearch-project#14672) * Bump com.github.spullara.mustache.java:compiler Bumps [com.github.spullara.mustache.java:compiler](https://github.com/spullara/mustache.java) from 0.9.13 to 0.9.14. - [Commits](spullara/mustache.java@mustache.java-0.9.13...mustache.java-0.9.14) --- updated-dependencies: - dependency-name: com.github.spullara.mustache.java:compiler dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * Bump net.minidev:accessors-smart from 2.5.0 to 2.5.1 in /plugins/repository-azure (opensearch-project#14673) * Bump net.minidev:accessors-smart in /plugins/repository-azure Bumps [net.minidev:accessors-smart](https://github.com/netplex/json-smart-v2) from 2.5.0 to 2.5.1. - [Release notes](https://github.com/netplex/json-smart-v2/releases) - [Commits](netplex/json-smart-v2@2.5.0...2.5.1) --- updated-dependencies: - dependency-name: net.minidev:accessors-smart dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * move query group thread context propagator out of ThreadContext Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: vatsal <[email protected]> Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: Sachin Kale <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: Vatsal <[email protected]> Co-authored-by: Siddhant Deshmukh <[email protected]> Co-authored-by: Robin Friedmann <[email protected]> Co-authored-by: rishavz_sagar <[email protected]> Co-authored-by: Sooraj Sinha <[email protected]> Co-authored-by: Sachin Kale <[email protected]> Co-authored-by: Craig Perkins <[email protected]> Co-authored-by: Bharathwaj G <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add consumers to remote store based index settings (opensearch-project#14764) Signed-off-by: Shourya Dutta Biswas <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add matchesPluginSystemIndexPattern to SystemIndexRegistry (opensearch-project#14750) * Add matchesPluginSystemIndexPattern to SystemIndexRegistry Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Use single data structure to keep track of system indices Signed-off-by: Craig Perkins <[email protected]> * Address code review comments Signed-off-by: Craig Perkins <[email protected]> * Add test for getAllDescriptors Signed-off-by: Craig Perkins <[email protected]> * Update server/src/main/java/org/opensearch/indices/SystemIndexRegistry.java Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * SPI for loading ABC templates (opensearch-project#14659) * SPI for loading ABC templates Signed-off-by: mgodwan <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix bulk upsert ignores the default_pipeline and final_pipeline when the auto-created index matches the index template (opensearch-project#12891) * Fix bulk upsert ignores the default_pipeline and final_pipeline when auto-created index matches with the index template Signed-off-by: Gao Binlong <[email protected]> * Modify changelog & comment Signed-off-by: Gao Binlong <[email protected]> * Use new approach Signed-off-by: Gao Binlong <[email protected]> * Fix test failure Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix flaky test due to node being used across all tests (opensearch-project#14787) Signed-off-by: Mohit Godwani <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Star Tree Implementation [OnHeap] (opensearch-project#14512) --------- Signed-off-by: Sarthak Aggarwal <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add Gao Binlong as maintainer (opensearch-project#14796) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Clear ehcache disk cache files during initialization (opensearch-project#14738) * Clear ehcache disk cache files during initialization Signed-off-by: Sagar Upadhyaya <[email protected]> * Adding UT to fix line coverage Signed-off-by: Sagar Upadhyaya <[email protected]> * Addressing comment Signed-off-by: Sagar Upadhyaya <[email protected]> * Adding more Uts for better line coverage Signed-off-by: Sagar Upadhyaya <[email protected]> * Throwing exception in case we fail to clear cache files during startup Signed-off-by: Sagar Upadhyaya <[email protected]> * Adding more UTs Signed-off-by: Sagar Upadhyaya <[email protected]> * Adding a UT for more coverage Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing gradle build Signed-off-by: Sagar Upadhyaya <[email protected]> * Update ehcache disk cache close() logic Signed-off-by: Sagar Upadhyaya <[email protected]> --------- Signed-off-by: Sagar Upadhyaya <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Refactor remote-routing-table service inline with remote state interfaces (opensearch-project#14668) --------- Signed-off-by: Arpit Bandejiya <[email protected]> Signed-off-by: Arpit-Bandejiya <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Set version to 2.15 for determining metadata during migration to remote store Signed-off-by: Sandeep Kumawat <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix bulk upsert ignores the default_pipeline and final_pipeline when the auto-created index matches the index template (opensearch-project#14793) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix create or update alias API doesn't throw exception for unsupported parameters (opensearch-project#14769) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Change RCSS info logs to debug (opensearch-project#14814) Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * [Bugfix] Fix NPE in ReplicaShardAllocator (opensearch-project#13993) (opensearch-project#14385) * [Bugfix] Fix NPE in ReplicaShardAllocator (opensearch-project#13993) Signed-off-by: Daniil Roman <[email protected]> * Add fix info to CHANGELOG.md Signed-off-by: Daniil Roman <[email protected]> --------- Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Run performance benchmark on pull requests (opensearch-project#14760) * add performance benchmark workflow for pull requests Signed-off-by: Rishabh Singh <[email protected]> * Update PERFORMANCE_BENCHMARKS.md Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> * Update PERFORMANCE_BENCHMARKS.md Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> * Update .github/workflows/benchmark-pull-request.yml Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> * Update .github/workflows/benchmark-pull-request.yml Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> * Update .github/workflows/benchmark-pull-request.yml Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> * Update .github/workflows/benchmark-pull-request.yml Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> --------- Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * fix constant_keyword field type (opensearch-project#14807) Signed-off-by: kkewwei <[email protected]> test Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * [Remote Store Migration] Reconcile remote store based index settings during STRICT mode switch (opensearch-project#14792) Signed-off-by: Shourya Dutta Biswas <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add prefix mode verification setting for repository verification (opensearch-project#14790) * Add prefix mode verification setting for repository verification Signed-off-by: Ashish Singh <[email protected]> * Add UTs and randomise prefix mode repository verification Signed-off-by: Ashish Singh <[email protected]> * Incorporate PR review feedback Signed-off-by: Ashish Singh <[email protected]> --------- Signed-off-by: Ashish Singh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * add length check on comment body for benchmark workflow (opensearch-project#14834) Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add restore-from-snapshot test procedure for snapshot run benchmark config (opensearch-project#14842) Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix env variable name typo (opensearch-project#14843) Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Use circuit breaker in InternalHistogram when adding empty buckets (opensearch-project#14754) * introduce circuit breaker in InternalHistogram Signed-off-by: bowenlan-amzn <[email protected]> * use circuit breaker from reduce context Signed-off-by: bowenlan-amzn <[email protected]> * add test Signed-off-by: bowenlan-amzn <[email protected]> * revert use_real_memory change in OpenSearchNode Signed-off-by: bowenlan-amzn <[email protected]> * add change log Signed-off-by: bowenlan-amzn <[email protected]> --------- Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * [Remote State] Create interface RemoteEntitiesManager (opensearch-project#14671) * Create interface RemoteEntitiesManager Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Optimise TransportNodesAction to not send DiscoveryNodes for NodeStat… (opensearch-project#14749) * Optimize TransportNodesAction to not send DiscoveryNodes for NodeStats, NodesInfo and ClusterStats call Signed-off-by: Pranshu Shukla <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Enabling term version check on local state for all ClusterManager Read Transport Actions (opensearch-project#14273) * enabling term version check on local state for all admin read actions Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Reduce logging in DEBUG for MasterService:run (opensearch-project#14795) * Reduce logging in DEBUG for MasteService:run by introducing short and long summary in Taskbatcher Signed-off-by: Sumit Bansal <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add SplitResponseProcessor to Search Pipelines (opensearch-project#14800) * Add SplitResponseProcessor for search pipelines Signed-off-by: Daniel Widdis <[email protected]> * Register the split processor factory Signed-off-by: Daniel Widdis <[email protected]> * Address code review comments Signed-off-by: Daniel Widdis <[email protected]> * Avoid list copy by casting array Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add integration tests for RemoteRoutingTable Service. (opensearch-project#14631) Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add SortResponseProcessor to Search Pipelines (opensearch-project#14785) * Add SortResponseProcessor for search pipelines Signed-off-by: Daniel Widdis <[email protected]> * Add stupid and unnecessary javadocs to satisfy overly strict CI Signed-off-by: Daniel Widdis <[email protected]> * Split casting and sorting methods for readability Signed-off-by: Daniel Widdis <[email protected]> * Register the sort processor factory Signed-off-by: Daniel Widdis <[email protected]> * Address code review comments Signed-off-by: Daniel Widdis <[email protected]> * Cast individual list elements to avoid creating two lists Signed-off-by: Daniel Widdis <[email protected]> * Add yamlRestTests Signed-off-by: Daniel Widdis <[email protected]> * Clarify why there's unusual sorting Signed-off-by: Daniel Widdis <[email protected]> * Use instanceof instead of isAssignableFrom Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix allowUnmappedFields, mapUnmappedFieldAsString settings to be applied when parsing query string query (opensearch-project#13957) * Modify to invoke QueryShardContext.fieldMapper() method to apply allowUnmappedFields and mapUnmappedFieldAsString settings Signed-off-by: imyp92 <[email protected]> * Add test cases to verify returning 400 responses if unmapped fields are included for some types of query Signed-off-by: imyp92 <[email protected]> * Add changelog Signed-off-by: imyp92 <[email protected]> --------- Signed-off-by: imyp92 <[email protected]> Signed-off-by: gaobinlong <[email protected]> Co-authored-by: gaobinlong <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump com.microsoft.azure:msal4j from 1.16.0 to 1.16.1 in /plugins/repository-azure (opensearch-project#14857) * Bump com.microsoft.azure:msal4j in /plugins/repository-azure Bumps [com.microsoft.azure:msal4j](https://github.com/AzureAD/microsoft-authentication-library-for-java) from 1.16.0 to 1.16.1. - [Release notes](https://github.com/AzureAD/microsoft-authentication-library-for-java/releases) - [Changelog](https://github.com/AzureAD/microsoft-authentication-library-for-java/blob/dev/changelog.txt) - [Commits](AzureAD/microsoft-authentication-library-for-java@v1.16.0...v1.16.1) --- updated-dependencies: - dependency-name: com.microsoft.azure:msal4j dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * Bump com.gradle.develocity from 3.17.5 to 3.17.6 (opensearch-project#14856) * Bump com.gradle.develocity from 3.17.5 to 3.17.6 Bumps com.gradle.develocity from 3.17.5 to 3.17.6. --- updated-dependencies: - dependency-name: com.gradle.develocity dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * Bump org.jline:jline in /test/fixtures/hdfs-fixture (opensearch-project#14859) Bumps [org.jline:jline](https://github.com/jline/jline3) from 3.26.2 to 3.26.3. - [Release notes](https://github.com/jline/jline3/releases) - [Changelog](https://github.com/jline/jline3/blob/master/changelog.md) - [Commits](jline/jline3@jline-parent-3.26.2...jline-parent-3.26.3) --- updated-dependencies: - dependency-name: org.jline:jline dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * Use Lucene provided Persian stem (opensearch-project#14847) Lucene provided Persian stem apparently isn't hooked yet and this change is doing that based on what is done for Arabic stem support. Signed-off-by: Ebrahim Byagowi <[email protected]> Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Bump actions/checkout from 2 to 4 (opensearch-project#14858) * Bump actions/checkout from 2 to 4 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]> * Deprecate batch_size parameter on bulk API (opensearch-project#14725) By default the full _bulk payload will be passed to ingest processors as a batch, with any sub batching logic to be implemented by each processor if necessary. Signed-off-by: Liyun Xiu <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Add perms for remote snapshot cache eviction on scripted query (opensearch-project#14411) Signed-off-by: Finn Carroll <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * add transport interceptor to populate queryGroupId in task headers Signed-off-by: Kaushal Kumar <[email protected]> * Add rest, transport layer changes for Hot to warm tiering - dedicated setup (opensearch-project#13980) Signed-off-by: Neetika Singhal <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Create listener to refresh search thread resource usage (opensearch-project#14832) * [bug fix] fix incorrect coordinator node search resource usages Signed-off-by: Chenyang Ji <[email protected]> * fix bug on serialization when passing task resource usage to coordinator Signed-off-by: Chenyang Ji <[email protected]> * add more unit tests Signed-off-by: Chenyang Ji <[email protected]> * remove query insights plugin related code Signed-off-by: Chenyang Ji <[email protected]> * create per request listener to refresh task resource usage Signed-off-by: Chenyang Ji <[email protected]> * Make new listener API public Signed-off-by: Siddhant Deshmukh <[email protected]> * Add changelog Signed-off-by: Siddhant Deshmukh <[email protected]> * Remove wrong files added Signed-off-by: Siddhant Deshmukh <[email protected]> * Address review comments Signed-off-by: Siddhant Deshmukh <[email protected]> * Build fix Signed-off-by: Siddhant Deshmukh <[email protected]> * Make singleton Signed-off-by: Siddhant Deshmukh <[email protected]> * Address review comments Signed-off-by: Siddhant Deshmukh <[email protected]> * Make sure listener runs before plugin listeners Signed-off-by: Siddhant Deshmukh <[email protected]> * Spotless Signed-off-by: Siddhant Deshmukh <[email protected]> * Minor fix Signed-off-by: Siddhant Deshmukh <[email protected]> --------- Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: Jay Deng <[email protected]> Co-authored-by: Chenyang Ji <[email protected]> Co-authored-by: Jay Deng <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Caching avg total bytes and avg free bytes inside ClusterInfo (opensearch-project#14851) Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Use default value when index.number_of_replicas is null (opensearch-project#14812) * Use default value when index.number_of_replicas is null Signed-off-by: Liyun Xiu <[email protected]> * Add integration test Signed-off-by: Liyun Xiu <[email protected]> * Add changelog Signed-off-by: Liyun Xiu <[email protected]> --------- Signed-off-by: Liyun Xiu <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * [Remote Routing Table] Implement write and read flow for shard diff file. (opensearch-project#14684) * Implement write and read flow to upload/download shard diff file. Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Optimized ClusterStatsIndices to precomute shard stats (opensearch-project#14426) * Optimize Cluster Stats Indices to precomute node level stats Signed-off-by: Pranshu Shukla <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Fix constraint bug which allows more primary shards than average primary shards per index (opensearch-project#14908) Signed-off-by: Gaurav Bafna <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * Optmising AwarenessAllocationDecider for hashmap.get call (opensearch-project#14761) Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * update comment Signed-off-by: Kaushal Kumar <[email protected]> * Fix IngestServiceTests.testBulkRequestExecutionWithFailures (opensearch-project#14918) The test would previously fail if the randomness led to only a single indexing request being included in the bulk payload. This change guarantees multiple indexing requests in order to ensure the batch logic kicks in. Also replace some unneeded mocks with real classes. Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]> * add queryGroupTask Signed-off-by: Kaushal Kumar <[email protected]> * remove unnecessary imports Signed-off-by: Kaushal Kumar <[email protected]> * add QueryGroupTask tests Signed-off-by: Kaushal Kumar <[email protected]> * rename WLM transport request handler Signed-off-by: Kaushal Kumar <[email protected]> * add CHANGELOG entry Signed-off-by: Kaushal Kumar <[email protected]> * fix ut Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * fix UT to remove the verify for final method Signed-off-by: Kaushal Kumar <[email protected]> * apply spotless Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]> Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Sandesh Kumar <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: Lukáš Vlček <[email protected]> Signed-off-by: kkewwei <[email protected]> Signed-off-by: Swetha Guptha <[email protected]> Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: ahmedsobeh <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: vatsal <[email protected]> Signed-off-by: Sachin Kale <[email protected]> Signed-off-by: Shourya Dutta Biswas <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: mgodwan <[email protected]> Signed-off-by: Mohit Godwani <[email protected]> Signed-off-by: Sagar Upadhyaya <[email protected]> Signed-off-by: Sandeep Kumawat <[email protected]> Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Daniil Roman <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: Ashish Singh <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: Pranshu Shukla <[email protected]> Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]> Signed-off-by: Sumit Bansal <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: imyp92 <[email protected]> Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Ebrahim Byagowi <[email protected]> Signed-off-by: Liyun Xiu <[email protected]> Signed-off-by: Finn Carroll <[email protected]> Signed-off-by: Neetika Singhal <[email protected]> Signed-off-by: Jay Deng <[email protected]> Signed-off-by: Gaurav Bafna <[email protected]> Signed-off-by: Andrew Ross <[email protected]> Co-authored-by: Shivansh Arora <[email protected]> Co-authored-by: Arpit-Bandejiya <[email protected]> Co-authored-by: gaobinlong <[email protected]> Co-authored-by: rishavz_sagar <[email protected]> Co-authored-by: Chenyang Ji <[email protected]> Co-authored-by: Craig Perkins <[email protected]> Co-authored-by: Sandesh Kumar <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Co-authored-by: Zelin Hao <[email protected]> Co-authored-by: Lukáš Vlček <[email protected]> Co-authored-by: kkewwei <[email protected]> Co-authored-by: SwethaGuptha <[email protected]> Co-authored-by: Sooraj Sinha <[email protected]> Co-authored-by: Ahmed Sobeh <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Siddhant Deshmukh <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: Vatsal <[email protected]> Co-authored-by: Robin Friedmann <[email protected]> Co-authored-by: Sachin Kale <[email protected]> Co-authored-by: Bharathwaj G <[email protected]> Co-authored-by: Shourya Dutta Biswas <[email protected]> Co-authored-by: Craig Perkins <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Co-authored-by: Mohit Godwani <[email protected]> Co-authored-by: Sarthak Aggarwal <[email protected]> Co-authored-by: Sagar <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]> Co-authored-by: Daniil Roman <[email protected]> Co-authored-by: Rishabh Singh <[email protected]> Co-authored-by: kkewwei <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Ashish Singh <[email protected]> Co-authored-by: bowenlan-amzn <[email protected]> Co-authored-by: Pranshu Shukla <[email protected]> Co-authored-by: rajiv-kv <[email protected]> Co-authored-by: Sumit Bansal <[email protected]> Co-authored-by: Daniel Widdis <[email protected]> Co-authored-by: shailendra0811 <[email protected]> Co-authored-by: Park, Yeongwu <[email protected]> Co-authored-by: ebraminio <[email protected]> Co-authored-by: Liyun Xiu <[email protected]> Co-authored-by: Finn <[email protected]> Co-authored-by: Neetika Singhal <[email protected]> Co-authored-by: Jay Deng <[email protected]> Co-authored-by: Gaurav Bafna <[email protected]> Co-authored-by: Andrew Ross <[email protected]>
Bukhtawar
reviewed
Oct 12, 2024
| @@ -100,7 +100,10 @@ protected Runnable cancelExistingRecoveryForBetterMatch( | |||
| Metadata metadata = allocation.metadata(); | |||
| RoutingNodes routingNodes = allocation.routingNodes(); | |||
| ShardRouting primaryShard = allocation.routingNodes().activePrimary(shard.shardId()); | |||
| assert primaryShard != null : "the replica shard can be allocated on at least one node, so there must be an active primary"; | |||
There was a problem hiding this comment.
@DaniilRoman do we know why this assertion had to be removed. @dblock In general I am not of fan of removing assertions, they exist in the system for a reason, we shouldn't let our guards down.
There was a problem hiding this comment.
@Bukhtawar the assertion has been replaced by an explicit null check, returning null instead of throwing an exception. Either way the code will not proceed past this point. There is a previous return null at line 98, so it seems null is already an expected return value.
There was a problem hiding this comment.
@dbwiddis If I am understanding this correct there are two things
- the method
cancelExistingRecoveryForBetterMatchis expected to return aRunnableto denote some work to cancel existing recovery. Anullas a method return type denotes no work is supposed to be done for cancelling. - the invariant that says for a given shard(replica) it's corresponding
primaryshould be non-null, since the code path is supposed to kick in for aninitialising replicacopy which can only be initialising once it's correspondingprimaryhas been assigned see the decider
So there are two different things that exist and equating them IMO is incorrect. Removing the assertion essentially says at this point of execution a primary shard can be null when the system was designed ensuring that it shouldn't?
There was a problem hiding this comment.
So there are two different things that exist and equating them IMO is incorrect. Removing the assertion essentially says at this point of execution a primary shard can be null when the system was designed ensuring that it shouldn't?
I haven't dug into the logic, but from the face of it, the previous situation is that the assertion causes an exception, and the exception isn't handled.
I've no objection to reverting this change if you think the exception should be caught and addressed elsewhere.
There was a problem hiding this comment.
I haven't dug into the logic, but from the face of it, the previous situation is that the assertion causes an exception, and the exception isn't handled.
Unfortunately assertions don't run outside tests and the stack trace isn't an assertion tripping. Even if an assertion is failing the right thing to do is investigate why it is failing rather than burying the problem, by removing the assertion(invariant) that was added
There was a problem hiding this comment.
#10254 didn't "fix" or modify the behavior of this method, I had just refactored ...
So I see looking again... sorry. The first time I was just looking for a line number. But now I'm really confused. In order for an NPE on line 108 on null primaryShard it would have had to pass the assertions on 106 and 107.
Is this just undefined/unpredictable behavior during JVM shutdown (node drop)?
In any case, seems a revert of this PR is the right action at this point.
There was a problem hiding this comment.
@Bukhtawar that's not the case with the assert keyword as it's used here. It throws an AssertionError.
As an Error it's not normally caught by exception catch blocks unless you're specifically looking for it, and by the traditional interpretation of Error means that it's an unrecoverable situation and the entire JVM should be shut down.
Sorry I don't think this is the correct understanding of how assert works. AssertionErrors are only configured for tests using a -ea JVM flag and in this case I don't think an AssertionError was triggered. Please feel free to read up more on this here
In any case, seems a revert of this PR is the right action at this point
Thanks for your understanding.
There was a problem hiding this comment.
Got it, and thanks for educating me.
So wouldn't an appropriate fix for the NPE then to both put the assert back and null check to avoid the exception? That seems odd but I've never really used assertions like this so at this point I really don't know the best approach.
There was a problem hiding this comment.
So wouldn't an appropriate fix for the NPE then to both put the assert back and null check to avoid the exception?
@dbwiddis The appropriate fix is to figure out why the invariant is being violated and fix that bug. i.e. if no primary exists, then there can be no recovery and this method should not be called. The previous behavior of having the code fail with an NPE is preferable to ignoring a situation that is not intended to be possible.
Slightly off topic, but in general I really dislike using the assert keyword. Instead of assert primaryShard != null : "message" I almost always prefer something like Objects.requireNonNull(primaryShard, "message") so that it deterministically fails in all situations. Only if the code is super performance critical and if the assertion check is computationally intensive do I think the assert keyword makes sense.
There was a problem hiding this comment.
The appropriate fix is to figure out why the invariant is being violated and fix that bug.
@andrross In general I agree.
In reality, I read the issue reporting this bug and it indicates it's happening during a node drop. Which means the JVM is shutting down for <insert reason here>. Which means undefined/unpredictable behavior.
TLDR: I'm not sure there is a bug, and the symptom may be a result of a JVM being shut down causing a node drop as a result of some totally unrelated thing.
There's not enough information in the issue to infer more.
shiv0408
added a commit
to shiv0408/OpenSearch
that referenced
this pull request
Oct 17, 2024
…#13993) (opensearch-project#14385)" This reverts commit cf0d6cc Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR fixes the NPE in ReplicaShardAllocator when we can't get an active primary shard.
Related Issues
Resolves #13993
Check List
Flaky test
org.opensearch.indices.IndicesRequestCacheIT.testCacheCleanupOnEqualStalenessAndThresholdis flaky #13503By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.